Increasing Signature Max Chars Feature Request »  Show posts from    to     

Icy Phoenix


General Support - Increasing Signature Max Chars Feature Request



MWE_001 [ Thu 11 Aug, 2016 20:10 ]
Post subject: Increasing Signature Max Chars Feature Request
Per MG request in another thread, he asked me to come over here and make a new thread.

Basically what I am after, in absolutely no hurry, is the ability to choose a user group of choice to be able to increase that usergroups max char count in sig.

For example, now it is set at 255 char. I have a group called Donors. Donors get special features on the board regular users do not get, more chars in sig is a nice feature to give.


Fer 10 [ Fri 12 Aug, 2016 17:59 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
I believe that this is posible if signature is a VarChar field in the table SQL and not a Text field, and the VarChar change for each rank in the admin panel, but i'm not a good Php developer.
Please wait to MG.


Informpro [ Fri 12 Aug, 2016 23:37 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
It's actually a bit more complex than that, because the field in the DB can't change depending on the group. It'll need some PHP mods. I'll get to it this month when I'm back home :-).


MWE_001 [ Sun 14 Aug, 2016 04:35 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
Well, this all was just a thought for me as a feature as described above. Without it, it is not a game changer for me. I am pretty clever at figuring out ways around things. But if this is possible months down the road or what ever then cool. If not, oh well was but a mere thought anyhow.

I appreciate your all's efforts on this project none the less in any way shape or form you offer it. This is a pretty cool cms


Take care folks!

Ray


Informpro [ Sun 21 Aug, 2016 22:44 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
Mh, it seems I lost the link to the old support topic... Do you still have it? Converting the mod should be rather quick.


mort [ Mon 22 Aug, 2016 01:39 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
Ahem! It's in the "similar topics"

http://www.icyphoenix.com/viewtopic.php?t=3969


MWE_001 [ Mon 22 Aug, 2016 04:33 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
lol sorry Inform. I was asked very nicely to stay out of old topics so I was staying true to my word that I would stear clear. MG had suggested I start this thread as a reminder to him but if you can port it, you the man!


Informpro [ Mon 22 Aug, 2016 21:20 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
mort wrote: [View Post]
Ahem! It's in the "similar topics"

http://www.icyphoenix.com/viewtopic.php?t=3969
I stopped believing in this feature a long time ago! Apparently wrongfully. Thank you.

I'm starting to see how to convert it now.


MWE_001 [ Mon 22 Aug, 2016 21:26 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
It's a feature one would never give a second thought to unless it was incentive for memberships for vendors or something like that. Like some boards you can choose who can use images and links in sigs and who cant and what groups get how many chars etc etc. That is a tad much really, but increasing chars per group would be awesome, BUT.... Not necessary by any means. I am clever and can find other incentives This was just a idea when I viewed that old topic.

As I said, not necessary though. I know you developers have enough going on without trying to add more to the package every time someone sends out a request. I can appreciate everything you guys do for the project in your own giving manner and I thank you all so very much. I would try to help but my skills are very limited to say the least. Now beta testing, I am a pro lol if it can go wrong, I will find it!


Informpro [ Mon 22 Aug, 2016 22:25 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
Okay, I'm done with the adaptation.

Here is the commit:

https://github.com/vendethiel/icy_p...a65cb8414209007

I can make a "phpBB mod changelog", or you can read it on github. Green lines are "added", Red lines are "removed" ( you can also look at the + and - signs)

The lang:
OPEN
Code: [Hide]
  1. language/lang_english/lang_admin.php 

FIND (near the end)
Code: [Hide]
  1. // ####################### [ Icy Phoenix Options END ] ####################### 
  2.  

BEFORE, ADD
Code: [Hide]
  1. 'Group_exclude_max' => 'Exclude groups from max signature requirement', 
  2. 'Group_exclude_max_explain' => 'List of groups that will be excluded for the signature length limit restriction.', 



@MG this shows that class_form's LIST_CHECKBOX is not ready for prime time:



But it saved me a lot of time still, overall.


Mighty Gorgon [ Sun 28 Aug, 2016 12:32 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
Thank you very much Informpro, for now I have just implemented your class_form.php suggestions... even if I have to check how that field works (it was used for a private plugin, and it worked properly in the past...).

I still have doubt if it is feasible to add this feature to Icy Phoenix as default... what do you think?


MWE_001 [ Sun 28 Aug, 2016 22:22 ]
Post subject: Re: Increasing Signature Max Chars Feature Request
If I may jump in, I'[m not sure I would make it default. I would think seriously if anything of a simple plugin. I know it is a feature that appealed to me, but it may not to any others. I would hate to see you have to go through the hassle of hard coding for something that could be a plugin maybe? On another note, I am not sure how the plugins work so My opinion might not even matter.




Powered by Icy Phoenix