Icy Phoenix

Old Support Topics - [bugs] Deprecated VARS?

Lopalong [ Thu 27 Aug, 2009 02:38 ]
Post subject: [bugs] Deprecated VARS?

Dunno if this is of any use to you until PHPv6 hits the marketplace. When from what I understand - It will have to be addressed. ?

Quote:
$HTTP_SERVER_VARS is no longer defined. Possible solution: Use $_SERVER instead or better (for backward compatibility) check both with isset.

Spoiler: [ Show ]

Code: [Hide] [Select]

album_rss.php (2 hits)

	Line 90: if ( !$no_limit && isset($HTTP_SERVER_VARS['HTTP_IF_MODIFIED_SINCE']) )

	Line 93: 	$NotModifiedSince = strtotime($HTTP_SERVER_VARS['HTTP_IF_MODIFIED_SINCE']);

admin_replace.php (2 hits)

	Line 31: $str_old = trim(htmlspecialchars($HTTP_POST_VARS['str_old']));

	Line 32: $str_new = trim(htmlspecialchars($HTTP_POST_VARS['str_new']));

includes/downloads/admin/dl_admin_files.php (4 hits)

	Line 500: 			$thumb_size = $HTTP_POST_FILES['thumb_name']['size'];

	Line 501: 			$thumb_temp = $HTTP_POST_FILES['thumb_name']['tmp_name'];

	Line 502: 			$thumb_name = $HTTP_POST_FILES['thumb_name']['name'];

	Line 504: 			if ($HTTP_POST_FILES['thumb_name']['error'] && $thumb_name)

includes/downloads/includes/dl_modcp.php (8 hits)

	Line 104: 		$thumb_size = $HTTP_POST_FILES['thumb_name']['size'];

	Line 105: 		$thumb_temp = $HTTP_POST_FILES['thumb_name']['tmp_name'];

	Line 106: 		$thumb_name = $HTTP_POST_FILES['thumb_name']['name'];

	Line 108: 		if ($HTTP_POST_FILES['thumb_name']['error'] && $thumb_name)

	Line 133: 		$file_size = $HTTP_POST_FILES['dl_name']['size'];

	Line 134: 		$file_temp = $HTTP_POST_FILES['dl_name']['tmp_name'];

	Line 135: 		$file_name = $HTTP_POST_FILES['dl_name']['name'];

	Line 146: 			if ($HTTP_POST_FILES['dl_name']['error'])

includes/downloads/includes/dl_upload.php (8 hits)

	Line 93: 		$thumb_size = $HTTP_POST_FILES['thumb_name']['size'];

	Line 94: 		$thumb_temp = $HTTP_POST_FILES['thumb_name']['tmp_name'];

	Line 95: 		$thumb_name = $HTTP_POST_FILES['thumb_name']['name'];

	Line 97: 		if ($HTTP_POST_FILES['thumb_name']['error'] && $thumb_name)

	Line 122: 		$file_size = $HTTP_POST_FILES['dl_name']['size'];

	Line 123: 		$file_temp = $HTTP_POST_FILES['dl_name']['tmp_name'];

	Line 124: 		$file_name = $HTTP_POST_FILES['dl_name']['name'];

	Line 138: 		if ($HTTP_POST_FILES['dl_name']['error'])

install/clean_tables_ip.php (3 hits)

	Line 92: if (isset($HTTP_POST_VARS['submit']))

	Line 94: 	reset($HTTP_POST_VARS);

	Line 95: 	while (list($key, $value) = each($HTTP_POST_VARS))

/ctracker/emergency.php (56 hits) VARIOUS HTTP etc.

@ spydie - See what you started!

spydie [ Thu 27 Aug, 2009 11:18 ]
Post subject: Re: [bugs] Deprecated VARS?

Did´nt start anything.

If you have a look at IP.1.3 script you´ll find all Vars like i´ve told you.

Lopalong [ Thu 27 Aug, 2009 12:11 ]
Post subject: Re: [bugs] Deprecated VARS?

I know, all I'm doing here is letting MG know that there are still some VARS in IPv1.3 that will no doubt cause problems when PHP goes to version 6. They don't cause problems at the moment because of the transitional stage from PHP4 to PHP5. But from what I understand, is that when PHPv.6 is being used, the existing "Old" VARS in IP will no longer function.

Forewarned = Forearmed, or so they say.

Mighty Gorgon [ Thu 27 Aug, 2009 23:19 ]
Post subject: Re: [bugs] Deprecated VARS?

Thanks for reporting... I have fixed them.

Lopalong [ Fri 28 Aug, 2009 10:05 ]
Post subject: Re: [bugs] Deprecated VARS?

Tutto quello che posso dire è che sono più che benvenute.

Inglese:
All I can say is that you are more than welcome.

Informpro [ Sat 05 Sep, 2009 15:45 ]
Post subject: Re: [bugs] Deprecated VARS?

Hum.
I'm sorry up this topic, but if I remember, phpBB (by default), do:
$HTTP_*_VARS = isset($HTTP_*_VARS)?$HTTP_*_VARS:$_*;

So ... It's really creating bug in PHP 6 ? because $HTTP_*_VARS is a copy $_* in case of $HTTP_*_VARS is not defined. (Ok, I think that nobody is running PHP3/4 now, but ...)

spydie [ Sat 05 Sep, 2009 15:52 ]
Post subject: Re: [bugs] Deprecated VARS?

Informpro

if you go through the most of the file´s in IP you´ll find $_* , There´s still a feww $HTTP_*_VARS left, but they´re be gonne in next IP patch or update

Lopalong [ Sat 05 Sep, 2009 23:58 ]
Post subject: Re: [bugs] Deprecated VARS?

$HTTP_*_VARS are deprecated, and if people / sites are still using them then that's their problem. Much like IE6. And IF people have "Old" script that they still want to use, then they will have to update it. - - - - - Time to move on - as they say.