015-0014 Admin Board Header Issues

The time now is Tue 16 Apr, 2024 22:29 • All times are UTC + 1 Hour [DST enabled]

015-0014 Admin Board Header Issues

Page 1 of 1

Zuker

Joined: August 2006
Posts: 2134
Location:

015-0014 Admin Board Header Issues

There are a few issues in adm/admin_board_header_banners.php

First one

Code: [Download] [Hide] [Select]

$phpbb_root_path = '../';

require_once($phpbb_root_path . 'extension.inc');

require_once('./pagestart.' . $phpEx);

Should be after

Code: [Download] [Hide] [Select]

if( !empty($setmodules) )

{

    $file = basename(__FILE__);

    $module['1200_Configuration']['190_MG_Configuration_Headers_Banners'] = $file;

    return;

}

Second it's that when giving header banners some code with ", the result was a in front of every "

To Fix it

Find

Code: [Download] [Hide] [Select]

$new[$config_name] = addslashes($new[$config_name]);

Replace with

Code: [Download] [Hide] [Select]

$new[$config_name] = str_replace("'", "''", $new[$config_name]);

And the last one it's an issue with PHP4

I think that might be an error here with it

Code: [Download] [Hide] [Select]

$new[$config_name] = ( isset($_POST[$config_name]) ) ? $_POST[$config_name] : $default_config[$config_name];

does PHP4 support $_POST? I don't remember, but some time ago i had some problems with it

____________
? Zuker - EDDB - LPM - Sharefields

#1 Sat 16 Jun, 2007 21:20

Sponsors	Icy Phoenix is an open source project, you can show your appreciation and support future development by donating to the project.

Mighty Gorgon

Luca Libralato

Joined: August 2006
Posts: 7191
Location:

Borgo San Michele

Re: 001-014 Admin Board Header Issues

You're right about the code block order in the adm/admin_board_header_banners.php file (and not only that one... but it is not a major issue).
The problem with slashes is not to be solved how you suggest... because it is wrong.
It has to be solved in this way:
OPEN includes/page_header.php
FIND

Code: [Download] [Hide] [Select]
Code: [Download] [Show]
    'HEADER_BANNER_CODE' => $board_config['header_banner_text'],
    'VIEWTOPIC_BANNER_CODE' => $board_config['viewtopic_banner_text'],

REPLACE WITH

Code: [Download] [Hide] [Select]
Code: [Download] [Show]
    'HEADER_BANNER_CODE' => stripslashes($board_config['header_banner_text']),
    'VIEWTOPIC_BANNER_CODE' => stripslashes($board_config['viewtopic_banner_text']),
No problem with the $_POST variable, it is working fine in PHP4 as well.

____________
Luca
SEARCH is the quickest way to get support.
Icy Phoenix ColorizeIt - CustomIcy - HON

#2 Wed 20 Jun, 2007 01:14

Zuker Joined: August 2006 Posts: 2134 Location: BA	Re: 001-014 Admin Board Header Issues Ok. Thanks Luca ____________ ? Zuker - EDDB - LPM - Sharefields
#3 Wed 20 Jun, 2007 12:15

Mighty Gorgon Luca Libralato Joined: August 2006 Posts: 7191 Location: Borgo San Michele	Re: 001-014 Admin Board Header Issues Please, let me know if this fixes the issues... since I don't have any error, I need someone else to test it for me. Thanks. ____________ Luca SEARCH is the quickest way to get support. Icy Phoenix ColorizeIt - CustomIcy - HON
#4 Wed 27 Jun, 2007 01:21

Zuker Joined: August 2006 Posts: 2134 Location: BA	Re: 001-014 Admin Board Header Issues Mighty Gorgon wrote: [View Post] Please, let me know if this fixes the issues... since I don't have any error, I need someone else to test it for me. Thanks. It works Mighty I ask at phpbb-es some users that got this error to fix it in your way and got no problems Topic locked as bug fixed ____________ ? Zuker - EDDB - LPM - Sharefields
#5 Fri 29 Jun, 2007 00:53

Mighty Gorgon Luca Libralato Joined: August 2006 Posts: 7191 Location: Borgo San Michele	Re: 001-014 Admin Board Header Issues Great... thanks. ____________ Luca SEARCH is the quickest way to get support. Icy Phoenix ColorizeIt - CustomIcy - HON
#6 Fri 29 Jun, 2007 01:41

Page 1 of 1

Was this topic useful?

Link this topic
URL
BBCode
HTML

The time now is Tue 16 Apr, 2024 22:29 • All times are UTC + 1 Hour [DST enabled]

Permissions List

You cannot post new topics
You cannot reply to topics
You cannot edit your posts
You cannot delete your posts
You cannot vote in polls
You cannot attach files
You can download files
You cannot post calendar events