Icy Phoenix

Hile, neighbours and friends...

Today I found a bug:

When a username has an apostrophe in it, something like "Roland's" or "Xusqui's" the last_visit_x_x.dat file generated has an error when created, as that apostrophe should have been treated as "Xusqui's", and not like "Xusqui's"... I hope you know what I mean...

i.e:



In the 9th line of the above code, where it says "(...) u=238">Finli o' Tego</a>, <a (...)" it should say "(...) u=238">Finli o/' Tego</a>, <a (...)"

The main problem of it is that when a user with an apostrophe logges in, the .dat file is generated with an error and the forum main page won't load (forum.php) givin' a "White screen of death".

I'm tired now, but if nobody tries to fix it I will try tomorrow afternoon...

Good night!!

Have you imported those users?

In XS users can't register with special characters such as ', so you should have disabled the mod that restricts the allowed characters for usernames.
Before I switched to XS my users had special characters in their usernames, and for this reason, after I switched to XS, they couldn't modify their profile.
They were too many to modify, so I just disabled the mod that restricts the allowed characters too.
But when those users logged in, I had your problem, so I find a solution... but that's not a "real" solution, 'cause I just let a script delete automatically that part of the cache each time it's called...
Here's what to do, you can use this until someone finds a good solution:
Make a file called delete.php with this code in it and upload it in your /xs/ folder:

Open /xs/templates/ca_aphrodite/overall_header.tpl
Find:

Before, add:

That's it... :roll:

Try changing your forum.php with this code:

Yes, ganesh, it's a phpBB Minerva forum ported to phpBB XS. With Minerva user's coud register with special characters. I didn't know they couldn't with XS...

Thank you a lot, MG... I'm going to apply your patch.

And... Would a normal, clean installation of phpBB XS be affected in anyway if the forum.php is replaced with the one you posted? As many people has phpBB XS migrated from other forums, could you leave this modification in further updates?

Well... I mean... I'm sorry, but I'm SO LAZY :oops: :oops: :oops: !!!! If you could leave this modification I wouldn't have to apply this patch to each new releas... :oops:

Just asking!

Thank you indeed again!!!!

PS: BTW it works pretty good :D :D :D

BTW... I changed all usernames... Security before all!

ganesh wrote: [View Post]

BTW... I changed all usernames... Security before all!

So... Do you think it's unsure to keep thos apostrophes? If so, I would change all that names too!!!!

I think that should be used an usercp_register.php when the user edits his profile, with the restrict characters mod removed, and the original usercp_register.php during the registration, this way who switched to xs from another package, won't have to rename users, old users still could modify their profile, and the restrict characters mod is applied just during the new registrations using xs...
Oh, and maybe the mod that Mighty wrote right up here, should be put in the standard phpBBXS package, so users who switched to xs won't have the blank page problem... ;) (these are just suggestions and what i think..)

Of course this modification will remail in XS.