|
Page 2 of 2
|
Joshua203
Joshua 203
Dutch A Go Go
Joined: August 2008
Posts: 1754
Location: Earth, Europe, the Netherlands, Rotterdam
|
Re: Black Pearl Extra Column
I also thought of adding an IF condition to remove the block but that would make post titles jump all over the place, which would look worse IMHO.
____________ www.DutchaGoGo.com (development/under construction ...Forever?¿?)
|
#16 Tue 20 Nov, 2012 23:57 |
|
Sponsors
|
Icy Phoenix is an open source project, you can show your appreciation and support future development by donating to the project.
|
|
mort
Spam Basher
Joined: August 2010
Posts: 998
Location: Up a tree
|
Re: Black Pearl Extra Column
No, this post shows why the normal forums are not affected, because if there is no post icon - It kills all the <td blah /td>
And I think MG will agree that search.html needs the same treatment.
http://www.icyphoenix.com/viewtopic.php?p=57530#p57530
|
#17 Wed 21 Nov, 2012 00:38 |
|
Joshua203
Joshua 203
Dutch A Go Go
Joined: August 2008
Posts: 1754
Location: Earth, Europe, the Netherlands, Rotterdam
|
Re: Bug - Blank Column In Black Pearl Search Results.
Well Mort lets wait and see if MG has a response
____________ www.DutchaGoGo.com (development/under construction ...Forever?¿?)
|
#18 Wed 21 Nov, 2012 00:43 |
|
St0ney
Joined: August 2009
Posts: 28
Location:
|
Re: Bug - Blank Column In Black Pearl Search Results.
Well Guys - I'm now a Happy Camper.
Mort - Thanks Again for the Code.
I can't Write Code, But I can "TWEAK IT" to what I'm looking For.
I took Your Code and made a Few Changes, (to fill my own likes)
I'm anally retentive when it comes to consistency
I read your prior Post above - and For me I only have to validate it
Here's What I changed (not going to Post the Code) For I'm sure MG will Code it to Hide things instead of Removing THEM -
Small Changes I wanted to make:
How it Looks Now:
Thanks again for The Help !!
St0ney
|
#19 Wed 21 Nov, 2012 01:09 |
|
mort
Spam Basher
Joined: August 2010
Posts: 998
Location: Up a tree
|
Re: Bug - Blank Column In Black Pearl Search Results.
I agree it looks nicer, but I wish you had posted your changes because I suspect that this line was removed. ?
<th width="4%" nowrap="nowrap"> </th>
It still would give the correct number of <th columns to match the number of <td columns
But now if one adds post icons, there would be a blank/black space in the <th.
Anyway, enough said -
I could give many examples of how to pull things out and put them back for one or many options, but I'll let MG work out what he's going to do - As it's his theme to worry about how he's going to fix the "Public" release to cover both.
|
#20 Wed 21 Nov, 2012 05:17 |
|
St0ney
Joined: August 2009
Posts: 28
Location:
|
Re: Bug - Blank Column In Black Pearl Search Results.
I agree it looks nicer, but I wish you had posted your changes because I suspect that this line was removed. ?
<th width="4%" nowrap="nowrap"> </th>
Yepper I removed it, I know for a fact I will never add topic Icons. So it worked better for me to remove it.
My concern with posting the code, is if others decide to add the same code and at a later date "decide to add the Icons" it would screw up their board.
Like I stated this works for me, May not work for Others.
Here's the code change for the WHOLE Section (Because I also Edited the width on the Cells to make it look more like the rest of the Forums Pages)
Like " Last post" for Example, it was toooo Tight and it was showing on 3 lines. Making it wider took it to 2 lines.
I Added the START and END - for when I upgrade this Style in the Future it will stick out more to me for the file edits.
<!------------------------ START Edit Removed empty Block ------------------------>
<!-- IF S_SHOW_TOPICS -->
<div><div class="tbl-h-l"><div class="tbl-h-r"><div class="tbl-h-c"><div class="tbl-title">{L_SEARCH}</div></div></div></div>
<table class="tablebg" width="100%" cellpadding="0" cellspacing="0">
<tr>
<th colspan="2" nowrap="nowrap"> {L_TOPICS} </th>
<th nowrap="nowrap"> {L_AUTHOR} </th>
<th nowrap="nowrap"> {L_REPLIES} </th>
<th nowrap="nowrap"> {L_VIEWS} </th>
<th nowrap="nowrap"> {L_LAST_POST} </th>
</tr>
<!-- BEGIN searchresults -->
<tr valign="middle">
<td class="row1" width="25" align="center">{searchresults.TOPIC_FOLDER_IMG}</td>
<!-- IF searchresults.TOPIC_ICON_IMG -->
<td class="row1" width="25" align="center">
<img src="{T_ICONS_PATH}{searchresults.TOPIC_ICON_IMG}" width="{searchresults.TOPIC_ICON_IMG_WIDTH}" height="{searchresults.TOPIC_ICON_IMG_HEIGHT}" alt="" title="" />
</td>
<!-- ENDIF -->
<td class="row1" width="400">
<!-- IF searchresults.S_UNREAD_TOPIC --><a href="{searchresults.U_NEWEST_POST}">{NEWEST_POST_IMG}</a><!-- ENDIF -->
{searchresults.ATTACH_ICON_IMG} <a href="{searchresults.U_VIEW_TOPIC}" class="topictitle">{searchresults.TOPIC_TITLE}</a>
<!-- IF searchresults.S_TOPIC_UNAPPROVED or searchresults.S_POSTS_UNAPPROVED -->
<a href="{searchresults.U_MCP_QUEUE}">{searchresults.UNAPPROVED_IMG}</a>
<!-- ENDIF -->
<!-- IF searchresults.S_TOPIC_REPORTED -->
<a href="{searchresults.U_MCP_REPORT}">{REPORTED_IMG}</a>
<!-- ENDIF -->
<!-- IF searchresults.PAGINATION -->
<p class="gensmall"> [ {GOTO_PAGE_IMG}{L_GOTO_PAGE}: {searchresults.PAGINATION} ] </p>
<!-- ENDIF -->
<!-- IF searchresults.S_TOPIC_GLOBAL -->
<p class="gensmall">{L_GLOBAL}</p>
<!-- ELSE -->
<p class="gensmall">{L_IN} <a href="{searchresults.U_VIEW_FORUM}">{searchresults.FORUM_TITLE}</a></p>
<!-- ENDIF -->
</td>
<td class="row2" width="130" align="center"><p class="topicauthor">{searchresults.TOPIC_AUTHOR_FULL}</p></td>
<td class="row1" width="50" align="center"><p class="topicdetails">{searchresults.TOPIC_REPLIES}</p></td>
<td class="row2" width="50" align="center"><p class="topicdetails">{searchresults.TOPIC_VIEWS}</p></td>
<td class="row1" width="150" align="center">
<p class="topicdetails">{searchresults.LAST_POST_TIME}</p>
<p class="topicdetails">{searchresults.LAST_POST_AUTHOR_FULL}
<a href="{searchresults.U_LAST_POST}">{LAST_POST_IMG}</a>
</p>
</td>
</tr>
<!------------------------ END Edit Removed empty Block ------------------------>
Regards
St0ney
|
#21 Wed 21 Nov, 2012 14:56 |
|
mort
Spam Basher
Joined: August 2010
Posts: 998
Location: Up a tree
|
Re: Bug - Blank Column In Black Pearl Search Results.
That "Last Post" column has been under discussion many times for the way it never seems to want to conform width-wise.
Anyway, I'm glad you have it the way you want it.
Now all you need to do is test it with IE8 - 9, FF, Chrome and Opera and hope that you don't have to start pulling your hair out if they all don't render it the same.
Oh! the joys of theme making - - - It's enough to drive a man to drink.
|
#22 Wed 21 Nov, 2012 15:28 |
|
Mighty Gorgon
Luca Libralato
Joined: August 2006
Posts: 7191
Location: Borgo San Michele
|
Re: [SOLVED] Bug - Blank Column In Black Pearl Search Results.
About the solution proposed here: http://www.icyphoenix.com/viewtopic.php?p=57535#p57535
It won't work at all... because searchresults. loop has not been yet initialized... so you can't use to decide how to output in table header. The only solution is removing topic icons markup at all (honestly it is a feature I never liked...).
About the other solution regarding columns width, at the moment there is no easy solution, what works good for a person maybe it isn't that good for others... it's not easy to create a universal template which fits everyones' needs.
____________ Luca
SEARCH is the quickest way to get support.
Icy Phoenix ColorizeIt - CustomIcy - HON
|
#23 Sat 24 Nov, 2012 10:20 |
|
mort
Spam Basher
Joined: August 2010
Posts: 998
Location: Up a tree
|
Re: [SOLVED] Bug - Blank Column In Black Pearl Search Results.
The only solution is removing topic icons markup at all (honestly it is a feature I never liked...).
Just fill the blank space with <img src="Blah/search-icon.gif/png
You know - the little magnifying glass with a handle - -
That should keep them happy.
|
#24 Sat 24 Nov, 2012 11:02 |
|
Mighty Gorgon
Luca Libralato
Joined: August 2006
Posts: 7191
Location: Borgo San Michele
|
Re: [SOLVED] Bug - Blank Column In Black Pearl Search Results.
You know - the little magnifying glass with a handle - -
That should keep them happy.
He he he... we may try.
I've started few weeks ago to code a new feature for Icy Phoenix which allows to add an image to a post, which could be used as a reference for that post either in viewtopic or in news or in any other posts blocks. The main reason is that I often need such a feature and I think it could be useful for many.
If I ever manage to have the time to finish it, I'll implement.
____________ Luca
SEARCH is the quickest way to get support.
Icy Phoenix ColorizeIt - CustomIcy - HON
|
#25 Sat 24 Nov, 2012 11:29 |
|
spydie
Joined: December 2008
Posts: 1796
Location: In the Boxes
|
Re: [SOLVED] Bug - Blank Column In Black Pearl Search Results.
I´ve been tweaking around with a funktion, that should look for the first image in a post, to use it in another block, but the problem i had, was that the code worked only in html, but not with BBcode tags.
and i did not find a solution to it
____________ Out of Order
|
#26 Sat 24 Nov, 2012 11:33 |
|
Mighty Gorgon
Luca Libralato
Joined: August 2006
Posts: 7191
Location: Borgo San Michele
|
Re: [SOLVED] Bug - Blank Column In Black Pearl Search Results.
It's better to use the DB for such kind of features, it's a waste of resources using preg_replace to get such kind of things.
____________ Luca
SEARCH is the quickest way to get support.
Icy Phoenix ColorizeIt - CustomIcy - HON
|
#27 Sat 24 Nov, 2012 11:45 |
|
mort
Spam Basher
Joined: August 2010
Posts: 998
Location: Up a tree
|
Re: [SOLVED] Bug - Blank Column In Black Pearl Search Results.
I'm sure I could find a pair of binoculars icon that would suit that gap in the search template quite nicely.
|
#28 Sat 24 Nov, 2012 11:49 |
|
|
Page 2 of 2
|
Was this topic useful?
Was this topic useful?
Link this topic |
URL |
|
BBCode |
|
HTML |
|
Similar Topics
Similar Topics
You cannot post new topics You cannot reply to topics You cannot edit your posts You cannot delete your posts You cannot vote in polls You cannot attach files You can download files You cannot post calendar events
|
|
|
|