Icy Phoenix

that's great, Artie, thanks.

is it possible that this code could cause permission problems with new users?

since doing the above edits, new users now cannot delete their own photos in the main gallery, but are able to do it in their sub category "unrelated".. regardless of permission changes.

Hmmmm ... I will check into this :?

krisbfunk wrote: [View Post]

is it possible that this code could cause permission problems with new users?

since doing the above edits, new users now cannot delete their own photos in the main gallery, but are able to do it in their sub category "unrelated".. regardless of permission changes.

It should not cause any issues with the main gallery, but could with the sub cat (Unrelated) ... I'll correct this soon.

In the meantime review the thread linked below, it may be some of your problem

http://www.icyphoenix.com/viewtopic.php?t=791

Thanks Artie, but i already completed that update a while back and am aware of what it's saying.

settings:

users cannot create subcategories
users can create their own gallery
users can moderate their own galleries

config:
Who can view personal galleries by default: Private

group permissions:
usergroup #4: everything selected.. any modification to this at any time does nothing to the below settings


what new users in usergroup#4 see: (since this mod)

usergroups main personal gallery wrote: 

You can upload new photos in this category
You can post comments to photos in this category
You can edit your photos and comments in this category
You cannot delete your photos and comments in this category

You can moderate this category

usergroups UNRELATED personal gallery wrote: 

You can upload new photos in this category
You can post comments to photos in this category
You can edit your photos and comments in this category
You can delete your photos and comments in this category

You can moderate this category

I also should add this happens to every new user in any usergroup.

kris*, I think what is happening is that you have the group checked off as Is Moderator and that is pretty much the same as checking all the permission checkboxes. If you unchecked Is Moderator I think you will see the effect you desire.

On another note: The code (see below) given in an above post is incorrect and should be reversed.

Artie wrote: [View Post]

This will still show the Delete link for the sub-cat, but will only link to an unathorized message.


In code you added (above)

FIND (2nd instance of)

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

'" . ALBUM_PRIVATE . "'

REPLACE WITH

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

'1'

OPEN language_album_main.php

FIND

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

$lang['No_Personal_Category_admin'] = 'You are not allowed to manage your personal gallery categories';

AFTER ADD

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

$lang['No_Personal_Category_delete'] = 'You are not allowed to delete this personal gallery category';

OPEN album_personal_cat_admin.php


FIND

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

$sql = "SELECT cat_id, cat_title, cat_order
FROM ". ALBUM_CAT_TABLE ."
ORDER BY cat_order ASC";

REPLACE WITH

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

$sql = "SELECT cat_id, cat_title, cat_order, cat_delete_level
FROM ". ALBUM_CAT_TABLE ."
ORDER BY cat_order ASC";

FIND

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

if( $cat_found == FALSE )
{
message_die(GENERAL_ERROR, 'The requested category is not existed');
}

AFTER ADD

Code: [Download] [Hide] [Select]

Code: [Download] [Show]

if( ($thiscat['cat_delete_level'] == 1) && ($userdata['user_level'] != ADMIN))
{
include_once($phpbb_root_path . 'includes/page_header.'.$phpEx);
$message = $lang['No_Personal_Category_delete'];
$message .= "<br /><br />" . sprintf($lang['Click_return_album_index'], '<a href="' . append_sid(album_append_uid('album.' . $phpEx)) . '">', '</a>');
message_die(GENERAL_MESSAGE, $message);
}

Mod has been updated above

http://www.icyphoenix.com/viewtopic.php?p=6805#p6805

Artie.

Should all the old code be removed and then enter the new updated mod?

thanks, i updated the code.

as for the issue i'm having, the moderator box is not checked off for that usergroup.




main personal gallery:

Quote:

You can upload new photos in this category
You can post comments to photos in this category
You can edit your photos and comments in this category
You cannot delete your photos and comments in this category

You can moderate this category

unrelated personal gallery:

Quote:

You can upload new photos in this category
You can post comments to photos in this category
You can edit your photos and comments in this category
You can delete your photos and comments in this category

You can moderate this category

(this is only happening with new users since the unrelated mod)

Bullet wrote: [View Post]

Artie.

Should all the old code be removed and then enter the new updated mod?

Yes, I think that would be best.
You should also set cat_delete_level to 3 for all the Unrelated subcats you now have.


kris*, the only thing this mod could have done would have been ... You cannot delete your photos and comments in this category ... for the subcat Unrelated and not the main category. ... the updated mod will correct this on future galleries.

You are aware that Who can view personal galleries by default must be set to Private for any of those permissions to be active ?

Artie wrote: [View Post]

Bullet wrote: [View Post]

Artie.

Should all the old code be removed and then enter the new updated mod?

Yes, I think that would be best.
You should also set cat_delete_level to 3 for all the Unrelated subcats you now have.


kris*, the only thing this mod could have done would have been ... You cannot delete your photos and comments in this category ... for the subcat Unrelated and not the main category. ... the updated mod will correct this on future galleries.

You are aware that Who can view personal galleries by default must be set to Private for any of those permissions to be active ?

ok, i guess i should open a new topic then.. yes, i am aware Who can view personal galleries by default must be set to Private for the settings to take affect, and it is.

New users cannot delete photos in their main gallery, but they can delete photos in their Unrelated gallery. I have reset the permissions a number of times to even allow full access/no access and with and without moderator ability in the config. personal gallery delete permissions are not working on new users in any usergroup.

the only work-around i have for my users now is to have them move photos to their unrelated gallery and delete them from there.

*edit*

ok, i logged in as admin and deleted a new users personal gallery (both unrelated and main personal gallery). Then I logged in under that new user and created a gallery by clicking the create a personal gallery link. Now the new user can delete photos from both galleries. I have to do this for every new user.

When new accounts are created, the main gallery and unrelated is already created for them when they click their personal gallery link, perhaps this is part of the issue? It never used to be like this, new users previously had to click "create a personal gallery".

Artie,

Do you have all the previous code edits that u have PM me so I can remove them.

Bullet wrote: [View Post]

Artie,

Do you have all the previous code edits that u have PM me so I can remove them.

Most of the code is lined out above, the other is in album_mod/album_hierarchy_sql.php
Just replace what you have between this (below) with the code listed in the mod update.

krisbfunk wrote: [View Post]

When new accounts are created, the main gallery and unrelated is already created for them when they click their personal gallery link, perhaps this is part of the issue? It never used to be like this, new users previously had to click "create a personal gallery".

You have other problems, I would think.
How did that happen?
If ACP is set to allow users to create their own gallery they must be created this way.

Works great now! Thanks again!

Artie wrote: 

krisbfunk wrote: [View Post]

When new accounts are created, the main gallery and unrelated is already created for them when they click their personal gallery link, perhaps this is part of the issue? It never used to be like this, new users previously had to click "create a personal gallery".

You have other problems, I would think.
How did that happen?
If ACP is set to allow users to create their own gallery they must be created this way.

ok.. i'm not sure how it happened? ACP is set so to 'Private' for 'allowed to set personal gallery for users' and all usergroups are checked off in the personal galler permissions. The pre-existing galleries do not appear in the list of member galleries until someone has uploaded a photo, they do not get the link to create a gallery, it simply exists (unless i delete it, then they get the link).