Icy Phoenix

     
 


Post new topic  Reply to topic 
Page 3 of 4
Goto page Previous  1, 2, 3, 4  Next
 
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Lopalong wrote: [View Post]
You're welcome.

Re this: "but what if there gonna be changes in main (default one) common.css ?"

Yes it could cause some sort of small problems, but at the moment there's no other way to drop the image fade.

man but this your code worked
Code: [Download] [Hide] [Select]
$img_fade = '';
$img_fade_nm = '';

without changing common.css


Lopalong wrote: [View Post]

Re the Padding:

Code: [Download] [Hide] [Select]
You had this in your old cfg after the include line.

$extra_padding = '" style="margin-left:2px;'; (Which is slightly wrong) ;)

When this option already exists in the style.cfg

$extra_padding = in_array($color, $png_buttons_colors) ? '" style="margin-bottom:2px;' : '';

So just change that to:

$extra_padding = in_array($color, $png_buttons_colors) ? '" style="margin-left:2px;' : '';

or:

$extra_padding = in_array($color, $png_buttons_colors) ? '" style="margin-bottom:2px; margin-left:2px;' : '';

if you have to or want to.

this doesnt work
but this does
Code: [Download] [Hide] [Select]
$extra_padding = '" style="margin-left:2px;';

so i dunno what to do ,as u say "(Which is slightly wrong) "
 




____________
We are the phpBBorg. Lower your Crackers. Your phpological and forumological distinctivness will be added to our own. Resistance if futile!
 
LimunSend private messageVisit poster's website  
Back to topPage bottom
Icy Phoenix is an open source project, you can show your appreciation and support future development by donating to the project.

Support us
 
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Re this:

Code: [Download] [Hide] [Select]
$extra_padding = '" style="margin-left:2px;';


I already edited my other post.


Re This:

Code: [Download] [Hide] [Select]
$img_fade = '';
$img_fade_nm = '';


Mate, there seems to be a problem with the Vars overwriting previous vars unless the default.cfg is in the same folder as the style. And if MG wants to keep the default.cfg in the default folder, he's going to have to come up with some way that the var entries after the include line, actually force the changes to the default config.

I think it's better to shut off and wait until he looks at what the heck is happening here.

That's why I'm waiting for the final release before creating anything - because the RC's still need some testing.
 
 
 
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
  unfortunaly there also missing in nav q links

 nomenusep

at the end isnt better to have default.cfg in own style
(thats why i used it in my styles , it made me lot troubles when i didnt used it    in my style )

anyway we have to see what MG gona say

regarding you : how are you ?  
 




____________
We are the phpBBorg. Lower your Crackers. Your phpological and forumological distinctivness will be added to our own. Resistance if futile!
 
LimunSend private messageVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Limun wrote: [View Post]
At the end isnt better to have default.cfg in own style


It's not what MG planned on doing, but if there's no other alternative ??.    

Quote:
anyway we have to see what MG gona say


The way to go Captain Obvious!  

Quote:
regarding you : how are you ?  


Not too bad - but aren't we getting off-topic here?  




Catcha Later.  
 
 
 
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Lopalong wrote: [View Post]

Not too bad - but aren't we getting off-topic here?  

32
 




____________
We are the phpBBorg. Lower your Crackers. Your phpological and forumological distinctivness will be added to our own. Resistance if futile!
 
LimunSend private messageVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 



Hehehehe! Thought you might like a BIGGER one.  

Edit:

Limun, do you want to test this with vB_black?

It should fix the img_fade thing, and just add your changed images .png etc here ->

Code: [Download] [Hide] [Select]
// Start vB_black specific images

$images['menu_sep'] = $current_template_buttons . 'menu_sep.png';
$images['nav_menu_sep'] = $current_template_buttons . 'menu_sep.png';

// END vB_black specific images


vB_black.cfg

Spoiler: [ Show ]

 
 
 
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Lopalong wrote: [View Post]


Limun, do you want to test this with vB_black?


yes it work ...png in IE are ok now (fade is not working but pngs are normal what i wanted)
there also appaered menu_sep in drop down menu  

however i m a bit confused in all that below // SUDOKU - END  

thanks  
 




____________
We are the phpBBorg. Lower your Crackers. Your phpological and forumological distinctivness will be added to our own. Resistance if futile!
 
LimunSend private messageVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
All that below // SUDOKU - END re-establishes the template variables and some of them are probably a bit of overkill. But! - - - - the other alternative is to start adding arguments to the default.cfg for each and every variation to the style. And that is not going to be very useful as it would mean altering the default.cfg for any new style that required changes.

Or it would mean selecting different vars to add to the style.cfg (Could get messy)

I also can't see MG varying the default.cfg, because he would have to change all of his styles also to include the vars array in each style.cfg.

Maybe he may decide it's better to have the var array in the style.cfg only, and do it anyway. Who knows?

But at the moment, re-establishing the whole var array in the style.cfg takes the guesswork out of which vars to modify for what changes that need be added to it.

Now we can wait - wait - wait - for MG to decide, and tell us how he intends or would go about overcoming the problem.  

PS: When you say Fade is not working, do you mean that fade has been "Killed" or the buttons still have the glow effect.?
 
 
 
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Lopalong wrote: [View Post]

PS: When you say Fade is not working, do you mean that fade has been "Killed" or the buttons still have the glow effect.?

i mean this (this is no longer there) buttons are now ok.

 fadeie
 




____________
We are the phpBBorg. Lower your Crackers. Your phpological and forumological distinctivness will be added to our own. Resistance if futile!
 
LimunSend private messageVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
You had me worried there for a minute. Thanks for clearing it up.

C'mon MG - It's Your turn!  
 
 
 
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
I'm a bit lost in this huge topic...

I've spent ten minutes reading it, but I don't know if I have understood what is still open...

Can someone please recap which issues still need to be resolved?

Which vars should you need to overlay?

If you just need to overlay menu_sep, you can just add menu_sep template declaration at the end of your cfg file.

Code: [Download] [Hide] [Select]
include(IP_ROOT_PATH . 'templates/default/default.cfg');

$images['menu_sep'] = $current_template_buttons . 'menu_sep.png';
$images['nav_menu_sep'] = $current_template_buttons . 'menu_sep.png';

$template->assign_vars(array(
    'IMG_MENU_SEP' => $images['menu_sep'],
    'IMG_NAV_MENU_SEP' => '<img src="' . $images['nav_menu_sep'] . '" alt="" title="" />',
    )
);

 




____________
Luca
SEARCH is the quickest way to get support.
Icy Phoenix ColorizeIt - CustomIcy - HON
 
Mighty GorgonSend private messageSend e-mail to userVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Mighty Gorgon wrote: [View Post]
I'm a bit lost in this huge topic...


You caused it!  

Quote:

If you just need to overlay menu_sep, you can just add menu_sep template declaration at the end of your cfg file.


We already worked that out, but isn't that a BIG ask for a novice theme maker, to start adding vars to re-echo the changes to the strings ?

Only a suggestion, but would it not be easier to split the vars array from the default.cfg and do something like this ?

Code: [Download] [Hide] [Select]
include(IP_ROOT_PATH . 'templates/default/default.cfg');

// Start Put any forced changes to the default.cfg here.

$images['menu_sep'] = $current_template_buttons . 'menu_sep.png';
$images['nav_menu_sep'] = $current_template_buttons . 'menu_sep.png';

// END Put any forced changes to the default.cfg here.

include(IP_ROOT_PATH . 'templates/default/default_vars.cfg');


Else I'll simply remove all of the unwanted vars from the example I did, and we'll have to use that as the base for modded theme vars for all the images that theme makers may want to change.

I honestly don't think that most theme-makers are also programmers, so we'll give them the easiest way to do it, without having to work out what var belongs to what image etc..
 
 
 
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
I don't think so many designers will need to change the default.cfg... and most important... you can also decide to don't use default.cfg at all!!!

I have created a default one for my templates... but it is just a default one!

You can add all the vars you need in your CFG and avoid to use the INCLUDE.

Unfortunately making complex themes requires some extra editing in CFG... you cannot avoid that.
 




____________
Luca
SEARCH is the quickest way to get support.
Icy Phoenix ColorizeIt - CustomIcy - HON
 
Mighty GorgonSend private messageSend e-mail to userVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Mighty Gorgon wrote: [View Post]
I don't think so many designers will need to change the default.cfg... and most important... you can also decide to don't use default.cfg at all!!!

I have created a default one for my templates... but it is just a default one!

You can add all the vars you need in your CFG and avoid to use the INCLUDE.

Unfortunately making complex themes requires some extra editing in CFG... you cannot avoid that.

so we are here at begining  
u want to say that i can use your default.cfg in my folder styles ?
 




____________
We are the phpBBorg. Lower your Crackers. Your phpological and forumological distinctivness will be added to our own. Resistance if futile!
 
LimunSend private messageVisit poster's website  
Back to topPage bottom
Reply with quote Download Post 
Post Re: Sudoku Images For Dark Styles 
 
Didn't know you posted ahead of me Limun.  

@ MG

The only concern with not using and including the default/default.cfg is that should you make any important changes to the default.cfg in the way of upgrades etc, then those upgrades would not be accessible to any style that bypasses the default/default.cfg.



Ok, so anyone wanting to change image.ext etc, is going to have to learn how to re-define the strings and add them and the vars to the style.cfg. And that's no problem - So long as everyone knows that and does it the same way, then it wont become a headache for those trying to help.

  

@Limun - Why did you have to make those images .png ?  
 
 
 
Back to topPage bottom
Post new topic  Reply to topic  Page 3 of 4
Goto page Previous  1, 2, 3, 4  Next


Display posts from previous:    

HideWas this topic useful?

Link this topic
URL
BBCode
HTML




 
Permissions List
You cannot post new topics
You cannot reply to topics
You cannot edit your posts
You cannot delete your posts
You cannot vote in polls
You cannot attach files
You can download files
You cannot post calendar events


  

 

  cron