Icy Phoenix

General Support - [SSL] Problems With Images And HTTP/HTTPS

PlayerX [ Sun 12 Jun, 2016 08:11 ]
Post subject: [SSL] Problems With Images And HTTP/HTTPS

Version: 2.2.0.105 (new installation)
Web: https://battlefield-ng.com

I found several problems viewing images with SSL certificate, attach the photos to see.

If I find more problems with images, I'll put it here.

I follow his project for years, I like the way you have and the styles.

mort [ Sun 12 Jun, 2016 09:32 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

I'm not sure about this but I got it from Google..

Try adding ONLY ONE OF THESE to your .htaccess file

AFTER:

RewriteEngine On

ADD:

Code: [Hide] [Select]

RewriteCond %{HTTPS} off

RewriteRule ^(.*)$ https://%{HTTP_HOST}%{REQUEST_URI} [L,R=301]

Code: [Hide] [Select]

RewriteCond %{HTTPS} off

RewriteRule (.*) https://%{HTTP_HOST}%{REQUEST_URI} [R,L]

You may lock yourself out and have to clear your browser cache.

Informpro [ Sun 12 Jun, 2016 20:58 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

I think the best way would actually to use links without "http", as in "://imgur.com/...". I think it should work.

PlayerX [ Sun 12 Jun, 2016 23:24 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

The original idea is to look and fix them manually, but can not find.
I had solved temporarily "Redirect permanent" but was not the same.
I want to change it and try to put something like:

Code: [Hide]

$server_protocol = ($config['cookie_secure']) ? 'https://' : 'http://';

Fixed 1 of 3:

File: includes/functions_bbcode.php - Line 91 (smilies of "Quick Reply")

Code: [Hide]

'URL' => 'http://' . $host . $config['script_path'] . $config['smilies_path'] . '/' . $row['smile_url'], 
 

mort [ Mon 13 Jun, 2016 03:53 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

PlayerX wrote: [View Post]

File: includes/functions_bbcode.php - Line 91 (smilies of "Quick Reply")

Code: [Hide]
Code: [Show]
'URL' => 'http://' . $host . $config['script_path'] . $config['smilies_path'] . '/' . $row['smile_url'],

We've also got

functions_post.php

Line 729:

Code: [Hide] [Select]

'SMILEY_IMG' => 'http://' . $host . $config['script_path'] . $config['smilies_path'] . '/' . $rowset[$i]['smile_url'],

And if we change it to the "relative" path.

Code: [Hide] [Select]

'SMILEY_IMG' => './' . $config['smilies_path'] . '/' . $rowset[$i]['smile_url'],

It should work.

There's also this to deal with:

class_cache_extends.php

Code: [Hide] [Select]

	function obtain_smileys($from_cache = false)

	{

		global $db, $config;

		if (($smileys = $this->get('_smileys')) === false)

		{

			$smileys = array();

			$smileys_path = create_server_url() . $config['smilies_path'] . '/';

			$sql = "SELECT code, smile_url FROM " . SMILIES_TABLE . " ORDER BY smilies_order";

			$result = $from_cache ? $db->sql_query($sql, 0, 'smileys_') : $db->sql_query($sql);

			while ($row = $db->sql_fetchrow($result))

			{

				$smileys[] = array(

					'code' => $row['code'],

					'replace' => '<img src="' . $smileys_path . $row['smile_url'] . '" alt="" />'

				);

			}

			$db->sql_freeresult($result);

			$this->put('_smileys', $smileys);

		}

		return $smileys;

	}

I don't know if there is a global way to change all of this, so MG or informpro would be the ones to help sort this out..

PlayerX [ Mon 13 Jun, 2016 04:38 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

Already solved thanks to github

Informpro [ Mon 13 Jun, 2016 18:07 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

If you have a patch you want to submit, that'd be sweet!

Mighty Gorgon [ Wed 22 Jun, 2016 20:23 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

Thanks for reporting.

I will fix everything if you could help to keep track of all the changes.

PlayerX [ Wed 29 Jun, 2016 04:57 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

Recommend that when installing IP, place a checkbox for SSL, because it would have to change within mysql.

'cookie_secure'

Mighty Gorgon [ Sat 30 Jul, 2016 22:45 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

PlayerX wrote: [View Post]
Recommend that when installing IP, place a checkbox for SSL, because it would have to change within mysql.

'cookie_secure'

Thank you for the suggestion, I'll try to check if I can do that automatically.

Cristianita [ Mon 30 Apr, 2018 06:47 ]
Post subject: Re: [SSL] Problems With Images And HTTP/HTTPS

PlayerX wrote: [View Post]
Recommend that when installing IP, place a checkbox for SSL, because it would have to change within mysql.

'cookie_secure'

I'm sorry... I did it, but it didn't work...