Icy Phoenix

Archived phpBB Topics (Styles, Mods, Support) - FAP SUPPORT - Serveral Issues with FAP

Tom [ Thu 25 Jan, 2007 20:20 ]
Post subject: FAP SUPPORT - Serveral Issues with FAP

After I've updated to FAP 1.4.0a i was amazed how far the album has come. FAP is a great package. But if everything would work, I wouldn't post here. ;)

I have a couple of (possibly related) problems with the thumbnail generation and the watermark.
First of all I noticed, that the thumbnail quality setting is also the setting for the overall image quality when using a watermark. So if the thumbnail quality is set very low, the full pictures with watermark also have a very poor quality. I tried to increase the thumbnail quality and ended up setting it to 100% in order to have good quality full size images with watermark.
However, by doing so 2 new issues arose.
One, the thumbnails are now about 15-20kB instead of 3-5kB (which is not a bug, just not desirable).
Two, the lightbox preview doesn't work correctly anymore. The entire preview images is not loaded (see attached picture).

Then there is another thing: With lightbox preview is enabled the watermark is not transparent but has a black background. This is independent to the thumbnail quality setting.

It happens on my windows test system and on my linux online server. It seems to be unrelated to the server setup.

Any ideas?

And last but not least I found a hardcoded language variable in album_hotornot.php and fixed it. See attached code. ;)

To fix the hardcoded language in album_hotornot.php do the following:

Code: [Hide] [Select]

#

#-----[ OPEN ]------------------------------------------------

#

album_hotornot.php

#

#-----[ FIND ]------------------------------------------------

#

	$message = "Your rating has been entered successfully.<br /><br />To rate more pictures click <a href='append_sid(album_append_uid('album_hotornot.$phpEx'))'>here</a> to do so.<br /><br />" . sprintf($lang['Click_return_album_index'], "<a href="" . append_sid(album_append_uid("album.$phpEx")) . "">", "</a>");

#

#-----[ REPLACE WITH ]----------------------------------------

#

	$message = $lang['Rating_successful'] . sprintf($lang['Click_rate_more'], "<a href="" . append_sid(album_append_uid("album_hotornot.$phpEx")) . "">", "</a>") . sprintf($lang['Click_return_album_index'], "<a href="" . append_sid(album_append_uid("album.$phpEx")) . "">", "</a>");

#

#-----[ OPEN ]------------------------------------------------

#

language/lang_english/lang_album_main.php

#

#-----[ FIND ]------------------------------------------------

#

?>

#

#-----[ BEFORE, ADD ]-----------------------------------------

#

// Hot or Not

$lang['Rating_successful'] = 'Your rating has been entered successfully.<br /><br />';

$lang['Click_rate_more'] = 'To rate more pictures click %shere%s to do so.<br /><br />';

#

#-----[ SAVE/CLOSE ALL FILES ]--------------------------------

#

# EoM

lefty74 [ Thu 25 Jan, 2007 23:09 ]
Post subject: Re: Serveral Issues With FAP

Good finds Tom,

I never thought that the lightbox issue could have something to do with the thumbnail quality setting.
I had my thumbnails set to 100% quality as this is how I prefer them. I just put the quality to 80% and the pic in the lightbox seems to load without problems. I know this is not ideal but a quick fix. :shock:

For the watermark, for me it was different, some had the black background some were transparent.
Sorry I cannot actually be of any help but to confirm what you found.

Tom [ Fri 26 Jan, 2007 08:57 ]
Post subject: Re: Serveral Issues with FAP

Well... I'm known to find bugs fast and Mighty loves and hates me for that. :mrblue: I only installed it 2 days ago and noticed that there is something not right very soon. However I like to do some testing before posting possible bugs.

As for the image quality, there is only one setting for that (Thumbnail Quality) and it affects everything where GD handles the images. If you do not use Mid-Thumbnails and watermark, you won't have a problem with that.
Thumbnail Quality = Image Quality (if GD handles the images)

Mid-Thumbnail Settings: Those settings also affect the LightBox preview. So even if Mid-Thumb is deactivated (but LightBox enabled) these settings are relevant.
Therefore: Mid-Thumbnail settings = LightBox Preview settings
Why the Mid-Thumb doesn't fully load if the image quality is set to 100% - well that's something I'd like to know. And since I'm not the only one with this problem, I hope there'll be an answer soon. Migthy? ;)

As far as the Watermark goes, the problem with the transparency only shows with LightBox (possibly also with Mid-Thumb, but I haven't tested that because I don't like/use that feature). For full images Watermark works fine.

Artie [ Fri 26 Jan, 2007 18:38 ]
Post subject: Re: Serveral Issues with FAP

Tom wrote: [View Post]

And last but not least I found a hardcoded language variable in album_hotornot.php and fixed it.

It was my understanding that hot or not has been discontinued.... but I see the file is still there.... I wonder if it functions as intended.

Tom [ Fri 26 Jan, 2007 20:43 ]
Post subject: Re: Serveral Issues with FAP

Hmm... damn. I changed that for nothing then... although I think it's a fun feature.

Any ideas on all the other things Artie or is that something MG has to take a look at?

Artie [ Sat 27 Jan, 2007 04:14 ]
Post subject: Re: Serveral Issues with FAP

Tom, I don't think I can offer any help on these. I've not experienced these same issues surrounding the higher quality setting and the partial loading images. Maybe that's because I have my quality set at 75%..... I should raise it to 100% and check.

Mighty Gorgon [ Mon 05 Feb, 2007 01:36 ]
Post subject: Re: Serveral Issues with FAP

Can you please try using this file?

http://www.icyphoenix.com/viewtopic.php?p=8485#p8485