Icy Phoenix

Archived phpBB Topics (Styles, Mods, Support) - FAP SUPPORT - Only Png Mid Thumbnails Cached, No Jpg Thumbnails

sharkattaq [ Thu 11 Mar, 2010 12:40 ]
Post subject: FAP SUPPORT - Only Png Mid Thumbnails Cached, No Jpg Thumbnails

Hello,

Mid thumbnails are not cached correctly. Specifically, only png files are cached. Jpg files are not cached in mid thumbnail. So my mid thumbnail med_cache folder only has png files.

On the contrary, my small thumbnails cache correctly, both jpg and png files. So the cache directory is full of both png and jpg files.

There is no problem displaying all thumbnails, mid and small. Only caching of mid jpg thumbnails is the problem.

Anyone has any fix for this?

Mighty Gorgon [ Sun 14 Mar, 2010 09:51 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

Are you sure your JPG files are larger than the mid thumb size specified in ACP?

If actual JPG file is smaller than thumb size it should not be cached.

sharkattaq [ Sun 14 Mar, 2010 14:25 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

Yes, absolutely. My gallery has hundreds of very large pics. In the med_cache directory, however, there are only a few tens of mid thumbs, only png for the png photos of my gallery.

Mighty Gorgon [ Thu 25 Mar, 2010 10:38 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

Please provide me a link to the gallery.

Thanks.

sharkattaq [ Thu 25 Mar, 2010 12:47 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

I am sending you a pm.

sharkattaq [ Thu 01 Apr, 2010 19:39 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

I fixed this.

file album_picm.php line 423

Changed this line from

Code: [Hide] [Select]

			$Image->SendToFile($pic_thumbnail_new_fullpath, $album_config['thumbnail_quality']);

Code: [Hide] [Select]

			if ($pic_filetype == '.jpg')

			{

				$Image->SendToFileJPG($pic_thumbnail_new_fullpath, $album_config['thumbnail_quality']);			}

			else

			{

				$Image->SendToFile($pic_thumbnail_new_fullpath, $album_config['thumbnail_quality']);	

			}

Mighty Gorgon [ Fri 02 Apr, 2010 08:52 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

I thought I had already fixed that...

Anyway I might be wrong, because I'm not working on FAP for phpBB any more. I'm sure I have fixed that in Icy Phoenix FAP.

Since it seems you are good with PHP, should you need something else about thumbnails or album you can try to have a look at Icy Phoenix album code which includes an enhanced version of the old FAP.

Glad you solved your issue.

sharkattaq [ Fri 02 Apr, 2010 11:34 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

Thanks.

I didn't know that standalone FAP and IP FAP had many differences. From what I understand standalone FAP was stopped 2 years ago while IP FAP is still being evolved and fixed?

If we get IP FAP files to replace standalone FAP, does it work or are there too many differences?

PS: Checked and you were right. FAP code is not fixed, IP code had it fixed

Mighty Gorgon [ Sat 17 Apr, 2010 10:04 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

sharkattaq wrote: [View Post]
If we get IP FAP files to replace standalone FAP, does it work or are there too many differences?

I think it is not worth doing that, since it could require a lot of work... I have also used some IP specific functions in latest FAP which won't work in phpBB 2 unless you port them.

If you are ok with how FAP works now just stick with that. The only alternative I would consider is moving to phpBB 3 or Icy Phoenix.

sharkattaq [ Sun 18 Apr, 2010 18:49 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

FAP is great the way it is. Actually, it took some modding here and there to bring it how I wanted but now it's just great.

Mighty Gorgon [ Sat 08 May, 2010 11:13 ]
Post subject: Re: Only Png Mid Thumbnails Cached, No Jpg Thumbnails

Thanks, I appreciate.