UPI2DB System »  Show posts from    to     

Icy Phoenix


Old Bugs - UPI2DB System



Nizzle [ Thu 10 Aug, 2006 18:12 ]
Post subject: UPI2DB System
hmm this doesn't really seem to work yet
I like it though
or at least I liked what the FAQ said about it

I've enabled the "UPI2DB System"
and I've set this "Colorize topic title if there are new posts:" to yes
but now on forum every category is stuff marked in orange
when I click it there are no new posts in the category though


Tom [ Thu 10 Aug, 2006 19:26 ]
Post subject: Re: UPI2DB System
What template are you using? I've adapted and tested it with Aphrodite only.
I'm not sure MG implemented it in his templates already. But this is up to him.


Nizzle [ Thu 10 Aug, 2006 21:49 ]
Post subject: Re: UPI2DB System
using mg winter

but it's like this on all templates
already tried that


Mighty Gorgon [ Thu 10 Aug, 2006 23:52 ]
Post subject: Re: UPI2DB System
I'll check the whole UPI2DB soon.

Thanks for reporting.


Nizzle [ Fri 11 Aug, 2006 00:49 ]
Post subject: Re: UPI2DB System
pleasure mate


Tom [ Fri 11 Aug, 2006 15:16 ]
Post subject: Re: UPI2DB System
It does work with Aphrodite.


Tom [ Fri 11 Aug, 2006 15:22 ]
Post subject: Re: UPI2DB System
Here you can see how it should be:
packing


Nizzle [ Fri 11 Aug, 2006 22:23 ]
Post subject: Re: UPI2DB System
but with aphrodite I had the same thing
the unread color always stays

dunno about the thing you posted


Tom [ Sun 13 Aug, 2006 23:09 ]
Post subject: Re: UPI2DB System
Nizzle wrote: [View Post]
the unread color always stays
That is a bug with Announcements and Sticky topics. They aren't marked as read correctly.


moreteavicar [ Tue 26 Sep, 2006 00:39 ]
Post subject: Re: UPI2DB System
I've found another problem with UPI2DB - If you have a secret forum for say admins and mods, any posts made there will still get counted for normal users as new/unread posts, even though they can't actually view or read them!


KugeLSichA [ Tue 26 Sep, 2006 10:48 ]
Post subject: Re: UPI2DB System
moreteavicar wrote: [View Post]
I've found another problem with UPI2DB - If you have a secret forum for say admins and mods, any posts made there will still get counted for normal users as new/unread posts, even though they can't actually view or read them!


yes i can verify this.

i saw this some days ago here on xs.eu but dont find an solution yet

maybe Mighty has one


moreteavicar [ Tue 26 Sep, 2006 15:35 ]
Post subject: Re: BUG -UPI2DB System
I downloaded UPI2DB 3.0.6, and scanned through the code (both in included fles and in instructions) there doesn't appear to be anything to check for view authorisation! I was also trying to search through the UPI2DB website, it is all in German! But despite my limited understanding, it didn't look like there was a post on this (I think...), so maybe you could raise it on there, auf Deutsch, KugeLSichA?


KugeLSichA [ Tue 26 Sep, 2006 16:58 ]
Post subject: Re: UPI2DB System
im looking sometimes into that forum but the only this i read was with the recycle bin. but the problem have been fixed, i checked the code today.

maybe there is one other MOD how causes that problem.


moreteavicar [ Wed 27 Sep, 2006 15:01 ]
Post subject: Re: UPI2DB System
I think the problem is still that there is nothing in the code that checks for view permissions... also, going by the install notes, the only mod that can effect UPI2DB is Categories Heirarchy mod, but this only effects the topic listing (and thus any highlighting) - it has nothing to do with the tagging of new and unread posts (which is purely done by itself...)


moreteavicar [ Wed 27 Sep, 2006 15:27 ]
Post subject: Re: UPI2DB System
My suspicion to make this work properly is in the main function files, e.g. includes/upi2db/ upi2db_orig_lite.php

e.g. function set_unread()

in particular this statement:
Code: [Hide]
  1. if(isset($unread['mark_posts']) && in_array($p, $unread['mark_posts']))  
  2. {  
  3. $sql = "UPDATE " . UPI2DB_UNREAD_POSTS_TABLE . " SET status = '" . $mark_id . "' WHERE post_id = " . $p;  
  4. }  
  5. else  
  6. {  
  7. $sql = "INSERT INTO " . UPI2DB_UNREAD_POSTS_TABLE . "  
  8. (post_id, topic_id, forum_id, user_id, status, last_update, topic_type)  
  9. VALUES ('$p', '$t', '$f', '$user_id', '$mark_id', '$time', '$tt')";  
This requires a case structure checking view permissions


KugeLSichA [ Thu 28 Sep, 2006 10:38 ]
Post subject: Re: UPI2DB System
Hi moretecaviar,

i´m not sure if this is an problem of the original UPI2DB. I´m thinkin that this phpBBXS related, otherwise other users of UPI2DB should have found this bug.

I dont know why we have this error. And i tested it, that I can´t replicate this error

seen this also only here.


KugeLSichA [ Thu 28 Sep, 2006 11:07 ]
Post subject: Re: UPI2DB System
OK i found the error.

If you made an post in an normal forum, and after than you move this into an Forum with special rights (maybe Admin forum) the posts where counted as unread.

So i think its an prob of the Move posts MOD.

I have written the UPI2DB MOD author to verify if this is an prob of UPI2DB or an problem of our xs version. he asked me to translate the problem that we have, because his english is not very good, so i think its better if you (moreteavicar) post things about UPI2DB here on xs, and i report it in german to Bigrib (Author).

cya


moreteavicar [ Thu 28 Sep, 2006 14:11 ]
Post subject: Re: BUG -UPI2DB System
Thanks Holle, but I also saw this problem if I made a new post in a hidden area. And also, theory as well as experiment show this...
As I say, look in the UPI2DB files I mentioned - the way it works is that the function set_unread() adds to the UPI2DB database every recent post (i.e. whenever the function is called) - assigning a user_id (of the reader) to the post, so that it can be flagged as new or unread to the reader, depending on age and last logon. There is absolutely nothing to check for the view authorisation, so any new post made will get added to the UPI2DB unread table, and will appear as a new/unread post to the user, regardless of whether it is to a normal area or hidden area. So I can't see how it can be XS specific, nor down to using the lite version - even the full version has no view authorisation checking. If theres no authorisation checking, then theres no authorisation checking, and I can't see how else it can differentiate whether a user should be assigned to a post they cannot read in the unread_posts table. Does this make sense, or is this a case of me being completely mad in a world of sanity, (which to a philosopher is just as valid in the opposite sense)

Because fundamentally it doesn't check permissions, the problem will of course flag posts that have been moved to hidden areas as well! Maybe there is a difference because of the newer versions of UPI2DB. I'm using XS059rc3, but I see that 059 upi2DB files are identical to 058 anyhow, so the problem should be seen if you are using 058, and you create a completely hidden forum - with view auth of the forum and everthing within being admin. Make some new posts. Then log in immediately with a regular user test accout (depending on the likelihood of another user posting, confusing the issue!). You should see a few new posts counted at the top, and when you click to see them, you are told you cannot view them. Funnily enough, I cannot see the problem on this site, beause I'll have to go through all the 394 unread posts counted for me!

I've been a bit busy with other things at the moment, but I have a fix in mind (for me then, as it seems to be just me that sees this), and will try it hopefully soon!

Thanks for your help


KugeLSichA [ Thu 28 Sep, 2006 14:25 ]
Post subject: Re: UPI2DB System
i spoke with the MOD author and he has verified this BUG.

Its also in the vanilla phpBB. You dont need to do anything ATM. BigRib wrote in his forum, that he is working on an fix for that.

He has an thing in mind.

I´m checking the forum for that, and if the fix is out there i´ll report it here, so we can add it.

cya


moreteavicar [ Thu 28 Sep, 2006 14:37 ]
Post subject: Re: BUG -UPI2DB System
Cool! I'm not mad after all!


Mighty Gorgon [ Sun 01 Oct, 2006 14:11 ]
Post subject: Re: BUG -UPI2DB System
I'll try to check even this one.

Thanks for reporting.




Powered by Icy Phoenix