Icy Phoenix

Forum Location: Forum Link
phpBB 3.0.11
Black Pearl to Version: 1.6.9

Okay now for my Question

I've used Black Pearl for a few years now (Sharpest Style out there).

When you click on any of these:
View unanswered posts | View active topics
Mark forums read | View unread posts | View new posts | View your posts

There's a Extra Black Column - And it Just does not match the rest of the forum pages served.

So I would like to Remove the dead Box, Just don't know where to Look, and what to change.

Example:



I did search a lot and can't seem to find an answer.

Thanks in Advance,

St0ney

If understand you correct St0ney... you need to set a forum icon to FILLthis box, this way the box won''t be empty at all

Joshua:

I'm actually looking to remove it completely.
(does not seem, to serve a purpose) for me.

Thanks
St0ney

OK St0ney,

Just to make clear how it can look..... please take a close look at this forum and all the forum icons it has, each forum has its own nice little image.

Now if you are really sure you still want to remove this feature i promise to take a close look for you and assist you, it should not be too hard to do and it's certainly possible

However... I do need to have a good day to make sure I give you correct advice, atm my health is not very ok.... so I hope you can be a little patient and are willing to wait.

Or maybe someone else is willing to help???

Josh, I'm in no rush.

I had this Style loaded for years (+updates)

Yes I would still like to remove it. (it's more just to clean up the look of those Search boards).

I understand what your saying about the icons, but keep in mind, these are all just post. (Not Boards)
(in pearl (active topics) it does list the board name/section under the title of the post).

My goal is to have the Example above top - look the same as the example Bottom.

Honestly if this is going to take you ALL Day, I can Live with it
And well just bag it.

I've been still searching, and cant find what (page) where the code is that serves these pages.

Hope you feel better Soon !

St0ney

I think I'm in the right place;

viewforum_body.html

You should be able to turn this off in the ACP/Forums or just kill the script.

Thanks Mort:

But I found the correct Page to Edit. "search_results.html"

Now I just need the Code Change.





Thanks Guys !!

St0ney

You're right.

search_results.html

Find This:



Change it to this (Because these VARS appear be inside the <TD <!-- IF searchresults.TOPIC_ICON_IMG --> and <!-- ENDIF --> should be outside of it so that they don't bring up the blank space.

Thanks Mort:

I did some Changes Also, But Even though I got the Look I was looking For.
Doesn't mean it Proper coding -

So I'll try your code (so I'll save what Have as a backkup Plan B)

I'll let ya Know how Goes.........


St0ney

I missed something too - If the column is removed it affects the colspan of the sub-header.

So the replace fix is the better option but you also have to modify this.




To:




phpBB

LMAO !!

I was going to post this, Until I saw your next Post!


BTW: That top post was a porn Spammer
The photo's were good so we saved the post to a Private Board


Yep Were Good ta Go ! Looks much better with-out a blank Box.




I'm surprised this has not come up in the past.
During my search, I went to a lot of boards using this style, and they all had the Blank Box.
But then again - I let it stay that way too, for a few years -


Thank You !

St0ney

Congrats St0ney, Thanks for taking over Mort

You're welcome St0ney, and I'll leave it up to Joshua to report it as a cosmetic GUB because I would find it annoying too.

And it probably affects all the MG phpBB styles based on subsilver.

Anyway,

What about editing your first post and changing the title to.

bug - Blank Column in Black Pearl search results.

It may help others to find it a lot easier.

OT: Re the I am topic - -

I am wanting to meet - - - Naw! better not.

---

Joshua wrote: 

Thanks for taking over Mort

Do any more taking over and I'll be needing an Undertaker over.

heheheh.. just wanted you to know it's much appreciated Mort.

MG removing these would stop phpbb to validate the styles, because realy it's just a feature (called post icon!)
One could even force a default icon to fill the empty block when a user posts

I don't know how it would affect validation because the <!-- Arguments are on the wrong side of the request.

<?php relates to if(!empty($post_icon)) {then show the block};

So phpBB have it wrong if they have it coded to show the block <td etc. when there's nothing there to show.

Who cares - Maybe MG was as tired as I get when he wrote it.

I also thought of adding an IF condition to remove the block but that would make post titles jump all over the place, which would look worse imho.

No, this post shows why the normal forums are not affected, because if there is no post icon - It kills all the <td blah /td>

And I think MG will agree that search.html needs the same treatment.

http://www.icyphoenix.com/viewtopic.php?p=57530#p57530

Well Mort lets wait and see if MG has a response

Well Guys - I'm now a Happy Camper.

Mort - Thanks Again for the Code.

I can't Write Code, But I can "TWEAK IT" to what I'm looking For.

I took Your Code and made a Few Changes, (to fill my own likes)
I'm anally retentive when it comes to consistency

I read your prior Post above - and For me I only have to validate it

Here's What I changed (not going to Post the Code) For I'm sure MG will Code it to Hide things instead of Removing THEM -

Small Changes I wanted to make:



How it Looks Now:



Thanks again for The Help !!

St0ney

I agree it looks nicer, but I wish you had posted your changes because I suspect that this line was removed. ?

<th width="4%" nowrap="nowrap">&nbsp;</th>

It still would give the correct number of <th columns to match the number of <td columns

But now if one adds post icons, there would be a blank/black space in the <th.

Anyway, enough said -

I could give many examples of how to pull things out and put them back for one or many options, but I'll let MG work out what he's going to do - As it's his theme to worry about how he's going to fix the "Public" release to cover both.

mort wrote: [View Post]

I agree it looks nicer, but I wish you had posted your changes because I suspect that this line was removed. ?

<th width="4%" nowrap="nowrap">&nbsp;</th>

Yepper I removed it, I know for a fact I will never add topic Icons. So it worked better for me to remove it.
My concern with posting the code, is if others decide to add the same code and at a later date "decide to add the Icons" it would screw up their board.

Like I stated this works for me, May not work for Others.

Here's the code change for the WHOLE Section (Because I also Edited the width on the Cells to make it look more like the rest of the Forums Pages)
Like " Last post" for Example, it was toooo Tight and it was showing on 3 lines. Making it wider took it to 2 lines.






I Added the START and END - for when I upgrade this Style in the Future it will stick out more to me for the file edits.







Regards
St0ney

That "Last Post" column has been under discussion many times for the way it never seems to want to conform width-wise.

Anyway, I'm glad you have it the way you want it.

Now all you need to do is test it with IE8 - 9, FF, Chrome and Opera and hope that you don't have to start pulling your hair out if they all don't render it the same.

Oh! the joys of theme making - - - It's enough to drive a man to drink.

About the solution proposed here: http://www.icyphoenix.com/viewtopic.php?p=57535#p57535

It won't work at all... because searchresults. loop has not been yet initialized... so you can't use to decide how to output in table header. The only solution is removing topic icons markup at all (honestly it is a feature I never liked...).

About the other solution regarding columns width, at the moment there is no easy solution, what works good for a person maybe it isn't that good for others... it's not easy to create a universal template which fits everyones' needs.

Mighty Gorgon wrote: [View Post]

The only solution is removing topic icons markup at all (honestly it is a feature I never liked...).

Just fill the blank space with <img src="Blah/search-icon.gif/png

You know - the little magnifying glass with a handle - -

That should keep them happy.

mort wrote: [View Post]

You know - the little magnifying glass with a handle - -

That should keep them happy.

He he he... we may try.

I've started few weeks ago to code a new feature for Icy Phoenix which allows to add an image to a post, which could be used as a reference for that post either in viewtopic or in news or in any other posts blocks. The main reason is that I often need such a feature and I think it could be useful for many.

If I ever manage to have the time to finish it, I'll implement.

I´ve been tweaking around with a funktion, that should look for the first image in a post, to use it in another block, but the problem i had, was that the code worked only in html, but not with BBcode tags.

and i did not find a solution to it

It's better to use the DB for such kind of features, it's a waste of resources using preg_replace to get such kind of things.

I'm sure I could find a pair of binoculars icon that would suit that gap in the search template quite nicely.