Icy Phoenix

Ok so the no reply for 24 hour thing just kills me guys. lol I'm a bucket mouth. When i get going, I get going. Sometimes when we post, we have a very strong need to come back and post again a little while later. 24 hours no bump is very rough. IMO.

Anyway, on with the show.

I know I found more than one. I need to look but I know the first one right off the bat is the Feedback plugin. If installed, when someone goes to view a persons public profile, it totally breaks the page. It says that a template file is missing or not found.

Another one is while installing the Activity Mod. (Nice Job resurrecting that one by the way), the extra sql text file that is included , it says extra sql that may be needed. If you go to phpMyAdmin and try to inject the sql statements, it throws a sql error at line .... what ever number it was and to please check the manual blah blah blah.


I found another one or two as well. I will need to go look again.

*EDIT*

The links plugin, if you put your site info in the ACP and click submit, it does not seem to save the submitted info? If you go to the links page on your website and then copy the html to a clipboard to "link to our site" it copies all the html code, but under further review, it is not injecting the websites url so basically, that renders it useless.


I installed the album, so far so good no bugs that I found. I also have donations installed but yet to try it out. The Blogs seem ok as well. So far no issues with it that I can find.

Mh, the cash mod also breaks viewprofile. And it seems like my global block for guests only display for admins.

Couple more issues I found yesterday while messing with the plugins.

I was quick to judge the Album being good to go then I got hit with a couple kind of major issues.

First, Watermark feature is turned on and am seeing no water mark even though it is set to all users. I went in to public categories and gave a specific link to watermarks and still a no go. Ahhh admin!!! that is why I can't see the watermark right? Wrong! I logged out, went to view an image I uploaded to the album and it threw me an error as soon as the picture went to come up. it said it can not open picture ID# What ever because there was an error with the image. Odd, I just looked at it when i was logged in.

Moving on, Clicking the sitemap link results in this after I installed the album. Not sure what it did before album as I never clicked it.

[Icy Phoenix Debug] PHP Notice: in file /sitemap.php on line 270: include(ALBUM_MOD_PATHalbum_common.php): failed to open stream: No such file or directory
[Icy Phoenix Debug] PHP Notice: in file /sitemap.php on line 270: include(): Failed opening 'ALBUM_MOD_PATHalbum_common.php' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php:/usr/local/php55/lib/php')

The Album_Mod folder is missing in action. That is also why my water mark is not working I think. There is simply no folder. It's not there. Could be my issue with the images not opening if viewing as guest? Here is a link, again, not sure you can follow it but I'll try: http://prnt.sc/c2goa5

And no Nuffload due to no cig bin files included in the Album plugin?


That is all I found for now. These are major, minus the Nuffload I guess. I really never knew anyone who used it anyhow, but if the option is available in the ACP it might as well work as planned.

Ok man that is all I got for now. I am just trying to keep notes as I go and reporting them as I see them. If I find anymore, I'll let you all know.

Take care!

Ray

MWE_001 wrote: [View Post]

Ok so the no reply for 24 hour thing just kills me guys. lol I'm a bucket mouth. When i get going, I get going. Sometimes when we post, we have a very strong need to come back and post again a little while later. 24 hours no bump is very rough. IMO.

Why don't you just edit your last post in case you need? I think it can be "rough" as well bumping more than once per day!

MWE_001 wrote: [View Post]

I know I found more than one. I need to look but I know the first one right off the bat is the Feedback plugin. If installed, when someone goes to view a persons public profile, it totally breaks the page. It says that a template file is missing or not found.

I'll check this and report back!

MWE_001 wrote: [View Post]

Another one is while installing the Activity Mod. (Nice Job resurrecting that one by the way), the extra sql text file that is included , it says extra sql that may be needed. If you go to phpMyAdmin and try to inject the sql statements, it throws a sql error at line .... what ever number it was and to please check the manual blah blah blah.

I'll check this as well...

MWE_001 wrote: [View Post]

The links plugin, if you put your site info in the ACP and click submit, it does not seem to save the submitted info? If you go to the links page on your website and then copy the html to a clipboard to "link to our site" it copies all the html code, but under further review, it is not injecting the websites url so basically, that renders it useless.

I'll check!

MWE_001 wrote: [View Post]

I installed the album, so far so good no bugs that I found. I also have donations installed but yet to try it out. The Blogs seem ok as well. So far no issues with it that I can find.

Great to know that something is finally working!

Okay, I've had some time to investigate (I used a hotspot to download IP and the plugins).

So, one by one:

- the feedback plugin bug is caused because... The feedback plugin believes it's the album plugin. In the feedback plugin init code (plugins/feedback/common.php), this line is the issue:

The issue is that the album was already loaded, so plugin_name is equal to "album".

@MG this seems like a serious issue. We should probably remove this conditional, and force the plugin name anyway.


-----------

For the activity mod -- I think this one is a bit counterintuitive...
I havn't seen the extra sql file instruction, but anyway, we should remove this "install / uninstall" page from the ACP, and integrate the SQL queries into the plugin itself.

What I've done and works:
- install the plugin in the ACP
- ACP > Activity/Games > Install/Uninstall
- click "Install activity mod plus"
- visit activity.php



------


For the links plugins... Uhm, that one's a blunder... The field name for the site URL is site_url, but it's not present in the links config table, so it's discarded...

Informpro wrote: [View Post]

@MG this seems like a serious issue. We should probably remove this conditional, and force the plugin name anyway.

You're right about this... I need to keep this in mind for the future...

At the moment I have fixed it by adding $plugin_name = 'feedback'; in viewtopic and viewprofile... but I'll probably need to rethink the whole thing...

I think changing it to a simple

in the init code is enough. It's the only place it should be used anyway.

Then the same for other plugins. I don't think it's any worse than that.

Mighty Gorgon wrote: [View Post]

MWE_001 wrote: [View Post]

Ok so the no reply for 24 hour thing just kills me guys. lol I'm a bucket mouth. When i get going, I get going. Sometimes when we post, we have a very strong need to come back and post again a little while later. 24 hours no bump is very rough. IMO.

Why don't you just edit your last post in case you need? I think it can be "rough" as well bumping more than once per day!

Not a bad idea at all and will gladly do. I can see how bumping a topic could cause chaos real fast. So editing it is! thanks!

MWE_001 wrote: [View Post]

I know I found more than one. I need to look but I know the first one right off the bat is the Feedback plugin. If installed, when someone goes to view a persons public profile, it totally breaks the page. It says that a template file is missing or not found.

I'll check this and report back!

I see you guys are working on this one so I will stay out of it.

MWE_001 wrote: [View Post]

Another one is while installing the Activity Mod. (Nice Job resurrecting that one by the way), the extra sql text file that is included , it says extra sql that may be needed. If you go to phpMyAdmin and try to inject the sql statements, it throws a sql error at line .... what ever number it was and to please check the manual blah blah blah.

I'll check this as well...

And I tested this more today and still the sql extra is all I can find wrong. I have NOT installed cash mod yet to test it out with activity mod.

MWE_001 wrote: [View Post]

The links plugin, if you put your site info in the ACP and click submit, it does not seem to save the submitted info? If you go to the links page on your website and then copy the html to a clipboard to "link to our site" it copies all the html code, but under further review, it is not injecting the websites url so basically, that renders it useless.

I'll check!

Code: [Hide] [Select]

Code: [Show]

<a href="" target="_blank"><img src="" width="100" height="31" alt="Flaming Hot Peppers" /></a>

Notice in the href? No link to site? Take a look at this screenshot. it is after I put in all site info and clicked submit. The info just goes away. http://prntscr.com/c3qjt1 and this one is the main links page http://prntscr.com/c3qkrs

MWE_001 wrote: [View Post]

I installed the album, so far so good no bugs that I found. I also have donations installed but yet to try it out. The Blogs seem ok as well. So far no issues with it that I can find.

Great to know that something is finally working!

I spoke up on this one to soon Luca. I posted on site here a issue or tow I had with the album. I will refrain from posting again as I do not want to double post about the same issue. I will find the other post I made about the album and bump it for you as it was kind of a serious issue.