https://www.icyphoenix.com/viewtopic.php?f=35&t=8926
-----------------------------------
mort
Mon 11 Feb, 2013 09:42

Typo In Viewtopic.php
-----------------------------------
viewtopic.php

I was nosing around looking for something - -

[b]$$[/b]

[code linenumbers=false]$topic_user_from_flag = $$forum_topic_data['user_from_flag'][/code]

;)


-----------------------------------
Informpro
Mon 11 Feb, 2013 19:01

Re: Typo In Viewtopic.php
-----------------------------------
That's not a typo, that's just a dynamicly named variable. Look :

[code]$a = 50;
$foo = 'a';
echo $$foo; //prints 50[/code]


-----------------------------------
mort
Mon 11 Feb, 2013 22:08

Re: Typo In Viewtopic.php
-----------------------------------
Thanks,

I learn something everyday from here.  :mryellow: 

But the last time I did that as a typo - it caused me all sorts of grief. :(

So one just assumed - - -


-----------------------------------
Informpro
Mon 11 Feb, 2013 22:47

Re: Typo In Viewtopic.php
-----------------------------------
It can happen in little viewed files but usually something like this produces an error, and in the viewtopic I believe this would've been spotted.


-----------------------------------
mort
Tue 12 Feb, 2013 04:15

Re: Typo In Viewtopic.php
-----------------------------------
I believe anything about phpBB code that starts in one file, goes through half a dozen more and finally ends up in the tpl file? :(

The reason I was there is because I took the Country Flags mod DB and ported it to my playground and ended up adding the Country [b][i]automatically[/i][/b] to the flag both on the same line and mouse-over and inserting it into the user-profiles wherever the flag is shown and moused over.

Location - Becomes - "Paris, Rome or Oodnawoopwoop etc, and on mouse-over the alt/title is "Rome Italy" - "Paris France" etc.

As in the pic.

 [img]http://www.icyphoenix.com/files/images/8840/flag.jpg[/img] 

Trying to dig where all of that is put together in Icy/phpBB files and do the same thing for IP, is an exercise in itself :(

Maybe you would like to do it, because currently the only information one gets from the flag most of the time is that it's just a [i]"little coloured rectangle"[/i] made up from about 24-36px.  :lol:

To make a point - Mouse over my Flag here, and my location is "Behind You" - If it was "Behind You Australia" it would at least make some sense, because for me, like others - the flags that are used here denote nothing because of their size, and mean very little to anyone because there is seldom any Country recognition of the flag itself.

 :mrgreen:


-----------------------------------
Mighty Gorgon
Tue 19 Feb, 2013 23:22

Re: Typo In Viewtopic.php
-----------------------------------
Thanks for the suggestion, I'll think about this.


-----------------------------------
mort
Wed 20 Feb, 2013 01:26

Re: Typo In Viewtopic.php
-----------------------------------
My friend if it was easy for me to dig out I would have done it because it's such a bit of easy coding just to echo the "country_name" where the user flag = user id.

;)


