https://www.icyphoenix.com/viewtopic.php?f=1&t=7214&p=49405#p49405
-----------------------------------
Mighty Gorgon
Thu 01 Jul, 2010 19:44

Re: Icy Phoenix 1.3.11.64
-----------------------------------
[quote user="Danielc" post="49401"]Has the styles changed a lot? I'm interested in make my own style for my site, but i don't know if i would do better waiting for the next release.[/quote]
It should not be changed a lot... but if you want to realize all the changes you should try to compare templates with WinMerge.

[quote user="Danielc" post="49401"]Also, i have other suggestions related to the performance (yes, a few more XD) that i have done in my site. The first is use minify to compress an merge the CSS files and JS files (had i said it before?).[/quote]
I won't do it by default, I have coded some script for doing that automatically, but then I have decided to not implement it as default option. If I have enough time I will code a switch.

Anyway in my opinion it is not crucial... you can do it for your site just once and you are ok until next CSS change.

[quote user="Danielc" post="49401"]The second is related to posted_img_thumbnails.php (or bbcode.php). It would be better if it checks if the image is local and if its width and height are lesser than the max image size (that you can set up in ACP). In this case, there's no need to generate a thumbnail copying this file to the thumbnail path. It's better if you just link the original image path instead of linking the thumbnail path and also the original image path. This could be done with a few lines in bbcode.php and i think it increases a bit the performance.

FIND:
[code]if (strpos($pic_id, $users_images_path) !== false)
{
	$user_dir = str_replace($pic_filename, '', str_replace($users_images_path, '', $pic_id));
	$pic_thumbnail = $pic_filename;[/code]

AFTER ADD:
[code]
         $image_size = @getimagesize($img_url);
	 if($image_size[0] <= $board_config['thumbnail_size'] && $image_size[1] <=$board_config['thumbnail_size'])
	 {
		$thumb_exists = true;
	 }[/code]
[/quote]
I wonder why you take the time to look which part of the code generates the thumbnail but you didn't read all the code in that section. :lol: 

Do you know what this part of code means?

[codeblock]						if(file_exists($pic_thumbnail_fullpath))
						{
							$thumb_exists = true;
							$params['src'] = $server_url . str_replace(IP_ROOT_PATH, '', $pic_thumbnail_fullpath);
						}[/codeblock]

And what this part of code in image_thumbnail.php is for?
[codeblock]if(($pic_width < $config['thumbnail_size']) && ($pic_height < $config['thumbnail_size']))
{
	if($config['thumbnail_cache'] == true)
	{
		$copy_success = @copy($pic_fullpath, $pic_thumbnail_fullpath);
		@chmod($pic_thumbnail_fullpath, 0777);
	}[/codeblock]

I think it is quite self explaining... and this code is there also in 1.3. :lol:


[quote user="Danielc" post="49401"]Also, i haven't done this in my site, but it would be good if we add the width and height params to all images in the site. I don't know if this could increase drastically the memory usage or CPU usage, but if not, this could optimize the site. [/quote]
If images are not stored to DB there is no easy way to add width and height without reading image properties. If you force the system to determine width and height you are charging server CPU for that. I prefer charging client CPU instead of server one.

One of the other things in to do list is adding all posted images in a DB table. I'm still thinking about this option, because it has to be coded properly.

[quote user="zsolti10" post="49403"]Will language packs work with the new version?[/quote]
Old language packs won't work in new version. Changes should not be too much... even in this case WinMerge could help.


