Home •  Forum •  FAQ •  Search •  Recent Topics •  Memberlist •  Register •  Log in 
Forum » Icy Phoenix Support » Older Versions Archive » Old Support Topics

Issue With 1.0.11.11.001

This topic is locked: you cannot edit posts or make replies.

 

darkone
Quote
Posts: 168
Tue 10 Apr, 2007 13:03
Subject: Issue With 1.0.11.11.001
Hey Everyone

I applied the .001 patch to the RC and I found this issue after I will try to explain it the best I can :)

On the upgrade of the patch before I start. I made my changes too the files I needed too and uploaded all files and as far as I know all uploads were successful with no errors and I did those two delete statements to the DB. Everything else seems to be running just fine.

Ok I created some default avatars for the guest user and members that have not selected their avatars yet. So under the 'Configuration - Board - Set default avatar' I have it set 'Both'. And the paths are right I checked them and plus they got carried over from the upgrade.

Now the default icons show up in every place like the profile, user block, forum posting, etc... But the only place where now the avatars will not show up no matter what I do is in the 'Top Posters' block. It shows normal avatars fine just fine just not the default ones.

You can see the example just going to my site if you need more proof. Link is in the signature.

Also not sure if it was meant to be left out the version number on ICY is still set too 1.0.11.11 shouldn't it be 1.0.11.11.001?


-D1-

Profile PM  
Zuker
Quote
Posts: 2134 Location: BA
Tue 10 Apr, 2007 13:47
Subject: Re: Issue With 1.0.11.11.001
The version is ok

* 1 is the main version number
* 0 is the number of public releases
* 11 is the number of dev releases for each public releases
* 11 is the total number of releases

Profile PM   Website MSN Skype
darkone
Quote
Posts: 168
Tue 10 Apr, 2007 21:30
Subject: Re: Issue With 1.0.11.11.001
Anyone else running into this issue where default avatars don't show up in top poster block? They worked before the small update patch for 1.0.11.11 just not afterwards.

-D1-

Profile PM  
Mighty Gorgon
Quote
Posts: 7192 Location: Borgo San Michele
Wed 11 Apr, 2007 03:02
Subject: Re: Issue With 1.0.11.11.001
OPEN blocks/blocks_imp_top_posters.php

FIND
Code: [Download] [Hide] [Select]
if ($avatar_img == '')
{
$avatar_img = get_default_avatar($row['user_id']);
}


REPLACE WITH
Code: [Download] [Hide] [Select]
if ($poster_avatar == '')
{
$poster_avatar = get_default_avatar($row['user_id']);
}

Profile PM   Website
darkone
Quote
Posts: 168
Thu 12 Apr, 2007 04:57
Subject: Re: Issue With 1.0.11.11.001
Hey MG

Thanks for the response. There is a small issue. I'm looking at the 'blocks_imp_top_posters.php' from the 1.0.11.11 RC release and this is what the file looks like:

Code: [Download] [Hide]
  1. if ( !defined('IN_PHPBB') )  
  2. {  
  3. die('Hacking attempt');  
  4. }  
  5.  
  6. if(!function_exists(imp_top_posters_func))  
  7. {  
  8. function imp_top_posters_func()  
  9. {  
  10. global $lang, $template, $portal_config, $block_id, $board_config, $db, $phpEx;  
  11.  
  12. $sql = "SELECT username, user_id, user_posts, user_avatar, user_avatar_type, user_allowavatar  
  13. FROM " . USERS_TABLE . "  
  14. WHERE user_id <> " . ANONYMOUS . "  
  15. ORDER BY user_posts DESC LIMIT ". $portal_config['md_total_poster'][$block_id];  
  16. if( !($result = $db->sql_query($sql)) )  
  17. {  
  18. message_die(GENERAL_ERROR, 'Could not query users', '', __LINE__, __FILE__, $sql);  
  19. }  
  20.  
  21. if ( $row = $db->sql_fetchrow($result) )  
  22. {  
  23. $i = 0;  
  24. do  
  25. {  
  26. $username2 = $row['username'];  
  27. $row['username'] = color_group_colorize_name($row['user_id']);  
  28. $username = $row['username'];  
  29. $user_id = $row['user_id'];  
  30. $posts = ( $row['user_posts'] ) ? $row['user_posts'] : 0;  
  31. $poster_avatar = '';  
  32. if ( $row['user_avatar_type'] && $user_id != ANONYMOUS && $row['user_allowavatar'] )  
  33. {  
  34. switch( $row['user_avatar_type'] )  
  35. {  
  36. case USER_AVATAR_UPLOAD:  
  37. //$poster_avatar = ( $board_config['allow_avatar_upload'] ) ? '<img src="' . $board_config['avatar_path'] . '/' . $row['user_avatar'] . '" alt="" height="' . $portal_config['md_avatar_height'][$block_id] . '" border="0" />' : '';  
  38. $poster_avatar = ( $board_config['allow_avatar_upload'] ) ? '<img src="' . $board_config['avatar_path'] . '/' . $row['user_avatar'] . '" alt="" border="0" />' : '';  
  39. break;  
  40. case USER_AVATAR_REMOTE:  
  41. $poster_avatar = resize_avatar($row['user_avatar']);  
  42. break;  
  43. case USER_AVATAR_GALLERY:  
  44. //$poster_avatar = ( $board_config['allow_avatar_local'] ) ? '<img src="' . $board_config['avatar_gallery_path'] . '/' . $row['user_avatar'] . '" alt="" height="' . $portal_config['md_avatar_height'][$block_id] . '" border="0" />' : '';  
  45. $poster_avatar = ( $board_config['allow_avatar_local'] ) ? '<img src="' . $board_config['avatar_gallery_path'] . '/' . $row['user_avatar'] . '" alt="" border="0" />' : '';  
  46. break;  
  47. case USER_GRAVATAR:  
  48. $poster_avatar = ( $board_config['enable_gravatars'] ) ? '<img src="' . get_gravatar($row['user_avatar']) . '" alt="" border="0" />' : '';  
  49. break;  
  50. }  
  51. }  
  52. if ($poster_avatar == '')  
  53. {  
  54. $poster_avatar = '<img src="' . $board_config['default_avatar_users_url'] . '" alt="" border="0" />';  
  55. }  
  56.  
  57.  
  58. $template->assign_block_vars('topposter', array(  
  59. 'USERNAME' => $username,  
  60. 'POSTS' => $posts,  
  61. 'AVATAR_IMG' => $poster_avatar,  
  62. 'U_VIEWPOSTER' => append_sid(PROFILE_MG . '?mode=viewprofile&amp;' . POST_USERS_URL . '=' . $user_id),  
  63. 'U_VIEWPOSTS' => append_sid(SEARCH_MG . '?search_author=' . str_replace(array(' ', '?', '&'), array('%20', '%3F', '%26'), $username2) . '&amp;showresults=posts')  
  64. //'U_VIEWPOSTS' => append_sid(SEARCH_MG . '?search_author=' . htmlspecialchars($username2) . '&amp;showresults=posts')  
  65. )  
  66. );  
  67.  
  68. $i++;  
  69. }  
  70. while ( $row = $db->sql_fetchrow($result) );  
  71. }  
  72.  
  73. $template->assign_vars(array(  
  74. 'L_POSTS' => $lang['Posts']  
  75. )  
  76. );  
  77. }  
  78. }  
  79.  
  80. imp_top_posters_func();  
  81. ?>  
  82.  


The only thing that looks like what you suggested is this line:

Code: [Download] [Hide] [Select]
if ($poster_avatar == '')
{
$poster_avatar = '<img src="' . $board_config['default_avatar_users_url'] . '" alt="" border="0" />';
}


As you see it's different code than what you posted. Or am I supposed to replace all of that text with what you posted?

Thanks for the help.

-D1-

Profile PM  
brandsrus
Quote
Posts: 297 Location: Leeuwarden, The Netherlands
Thu 12 Apr, 2007 09:05
Subject: Re: Issue With 1.0.11.11.001
FIND

Code: [Download] [Hide] [Select]
if ($poster_avatar == '')
{
$poster_avatar = '<img src="' . $board_config['default_avatar_users_url'] . '" alt="" border="0" />';
}


REPLACE WITH

Code: [Download] [Hide] [Select]
if ($poster_avatar == '')
{
$poster_avatar = get_default_avatar($row['user_id']);
}


Try the above change, maybe it works!

Profile PM   Website
darkone
Quote
Posts: 168
Fri 13 Apr, 2007 04:21
Subject: Re: Issue With 1.0.11.11.001
Thanks Brandsrus

That did the trick. Just trying to figure out if it was copying over of a file that got messed up or if it was a code issue? Just want to make sure it doesn't happen again. :) Want to find all the bugs make ICY flawless ...

-D1-

Profile PM  
This topic is locked: you cannot edit posts or make replies.
 

Page 1 of 1


  
You cannot post new topics
You cannot reply to topics
You cannot edit your posts
You cannot delete your posts
You cannot vote in polls
You cannot attach files
You can download files
You cannot post calendar events

   

This is a "Lo-Fi" version of our main content. To view the full version with more information, formatting and images, please click here.

Powered by Icy Phoenix based on phpBB
Generation Time: 0.1199s (PHP: 15% SQL: 85%)
SQL queries: 10 - Debug Off - GZIP Enabled