Icy Phoenix :: View topic - FAP SUPPORT - Photo Album Addon V2 For PhpBB2 Ported

forgotz [ Sun 04 Sep, 2011 21:34 ]
Post subject: FAP SUPPORT - Photo Album Addon V2 For PhpBB2 Ported

Have nearly completed port of Photo Album Addon v2. All has gone well except one critical aspect and that is display of pics. Display scripts are album_pic and album_thumbnail. After much research and tinkering, have concluded that header info is mixing with image info and browsers will return saying image is corrupted. Following is screenshots and code from both display scripts. Any help at all with this, would be much appreciated - am going through the "losing my mind" phase right now

This is the display code from album_pic script

Code: [Hide]

switch ( $pic_filetype ) 
{ 
	case '.png': 
		header('Content-type: image/png'); 
		break; 
	case '.gif': 
		header('Content-type: image/gif'); 
		break; 
	case '.jpg': 
		header('Content-type: image/jpeg'); 
		break; 
	default: 
		die('The filename data in the DB was corrupted'); 
} 
 
readfile(ALBUM_UPLOAD_PATH  . $thispic['pic_filename']); 
 
exit; 
 

This is the display code from album_thumbnail

Code: [Hide]

 
if( ($pic_filetype != '.jpg') and ($pic_filetype != '.png') and ($pic_filetype != '.gif') ) 
{ 
	// -------------------------------- 
	// GD does not support GIF so we must SEND a premade No-thumbnail pic then EXIT 
	// -------------------------------- 
 
	header('Content-type: image/jpeg'); 
	readfile($images['no_thumbnail']); 
	exit; 
} 
else 
{ 
	// -------------------------------- 
	// Check thumbnail cache. If cache is available we will SEND & EXIT 
	// -------------------------------- 
 
	if( ($album_config['thumbnail_cache'] == 1) and ($pic_thumbnail != '') and file_exists(ALBUM_CACHE_PATH . $pic_thumbnail) ) 
	{ 
		switch ($pic_filetype) 
		{ 
		  case '.gif': 
			case '.jpg': 
				header('Content-type: image/jpeg'); 
				break; 
			case '.png': 
				header('Content-type: image/png'); 
				break; 
		} 
 
		readfile(ALBUM_CACHE_PATH . $pic_thumbnail); 
		exit; 
	} 
 
 
	// -------------------------------- 
	// Hmm, cache is empty. Try to re-generate! 
	// -------------------------------- 
 
	$pic_size = @getimagesize(ALBUM_UPLOAD_PATH . $pic_filename); 
	$pic_width = $pic_size[0]; 
	$pic_height = $pic_size[1]; 
 
	$gd_errored = FALSE; 
	switch ($pic_filetype) 
	{ 
	 case '.gif': 
      $read_function = 'imagecreatefromgif'; 
      $pic_filetype = '.jpg'; 
   break; 
		case '.jpg': 
			$read_function = 'imagecreatefromjpeg'; 
			break; 
		case '.png': 
			$read_function = 'imagecreatefrompng'; 
			break; 
	} 
 
	$src = @$read_function(ALBUM_UPLOAD_PATH  . $pic_filename); 
 
	if (!$src) 
	{ 
		$gd_errored = TRUE; 
		$pic_thumbnail = ''; 
	} 
	else if( ($pic_width > $album_config['thumbnail_size']) or ($pic_height > $album_config['thumbnail_size']) ) 
	{ 
		// ---------------------------- 
		// Resize it 
		// ---------------------------- 
 
		if ($pic_width > $pic_height) 
		{ 
			$thumbnail_width = $album_config['thumbnail_size']; 
			$thumbnail_height = $album_config['thumbnail_size'] * ($pic_height/$pic_width); 
		} 
		else 
		{ 
			$thumbnail_height = $album_config['thumbnail_size']; 
			$thumbnail_width = $album_config['thumbnail_size'] * ($pic_width/$pic_height); 
		} 
 
		$thumbnail = ($album_config['gd_version'] == 1) ? @imagecreate($thumbnail_width, $thumbnail_height) : @imagecreatetruecolor($thumbnail_width, $thumbnail_height); 
 
		$resize_function = ($album_config['gd_version'] == 1) ? 'imagecopyresized' : 'imagecopyresampled'; 
 
		@$resize_function($thumbnail, $src, 0, 0, 0, 0, $thumbnail_width, $thumbnail_height, $pic_width, $pic_height); 
	} 
	else 
	{ 
		$thumbnail = $src; 
	} 
 
	if (!$gd_errored) 
	{ 
		if ($album_config['thumbnail_cache'] == 1) 
		{ 
			// ------------------------ 
			// Re-generate successfully. Write it to disk! 
			// ------------------------ 
 
			$pic_thumbnail = $pic_filename; 
 
			switch ($pic_filetype) 
			{ 
				case '.jpg': 
					@imagejpeg($thumbnail, ALBUM_CACHE_PATH . $pic_thumbnail, $album_config['thumbnail_quality']); 
					break; 
				case '.png': 
					@imagepng($thumbnail, ALBUM_CACHE_PATH . $pic_thumbnail); 
					break; 
			} 
 
			@chmod(ALBUM_CACHE_PATH . $pic_thumbnail, 0777); 
		} 
 
 
		// ---------------------------- 
		// After write to disk, donot forget to send to browser also 
		// ---------------------------- 
 
		switch ($pic_filetype) 
		{ 
			case '.jpg': 
				@imagejpeg($thumbnail, '', $album_config['thumbnail_quality']); 
				break; 
			case '.png': 
				@imagepng($thumbnail); 
				break; 
		} 
 
		exit; 
	} 
	else 
	{ 
		// ---------------------------- 
		// It seems you have not GD installed :( 
		// ---------------------------- 
 
		header('Content-type: image/jpeg'); 
		readfile('images/nothumbnail.jpg'); 
		exit; 
	} 
} 
 

This is a screen of personal album page in Firefox (using thumbnail script)

This is a screen of personal album page in IE (using thumbnail script)

This is a screen of pic page in IE (using pic script)

This is a screen of pic page in Firefox (using pic script)

Joshua203 [ Sun 04 Sep, 2011 23:11 ]
Post subject: Re: Photo Album Addon V2 For PhpBB2 Ported

please use code tags around codes in posts forgotz, thanks in advance

Mighty Gorgon [ Wed 07 Sep, 2011 20:20 ]
Post subject: Re: Photo Album Addon V2 For PhpBB2 Ported

Hi, thank you very much for this file.

Can I please ask for which platform you did the port? Nuke?

forgotz [ Thu 08 Sep, 2011 00:26 ]
Post subject: Re: Photo Album Addon V2 For PhpBB2 Ported

You are welcome, something that I enjoy doing

Yes, it is for Nuke, currently at this site, http://php-evolved.com/. I also have a forum threads going on this topic here and here. As mentioned in those threads, everything is working, except PHP image generation scripts are not working (album_thumbnail.php and album_pic.php), or at least that appears to be the issue. Again, the port appears to be a success - except for the most important thing, the images will not display

Today, I started from scratch and did the port once again - still the same result. The resolution MUST be something simple. I implemented a new image class and nothing. Tried rewriting the .htaccess files and still nothing. Even downloaded the FAP and attempted a port, and that was even worse. That's all good though, because I don't want everything that comes with FAP. The port of Album Mod version 2.0.56 is all I want - clean, simple and well integrated. Visit php-evolved.com for yourself and see what I am talking about. Any help at all would be greatly appreciated. Below, I have attached the second port that I did today. Maybe this is above my pay grade, and I should leave it - but I do not wish to. Have come this far and everything else is working, it's just a shame that this one thing has tripped me up. Thanks for your reply and hope we can work together...

-K

forgotz [ Sat 10 Sep, 2011 08:16 ]
Post subject: Re: Photo Album Addon V2 For PhpBB2 Ported

Bump

Mighty Gorgon [ Mon 12 Sep, 2011 23:12 ]
Post subject: Re: Photo Album Addon V2 For PhpBB2 Ported

Just for testing purpose... can you please try to install Icy Phoenix on the same domain and test if images are shown fine in the album? At least we know that the problem is not server configuration.

I can then try to help in debugging.

Icy Phoenix

Archived phpBB Topics (Styles, Mods, Support) - FAP SUPPORT - Photo Album Addon V2 For PhpBB2 Ported